Re: [PATCH 1/2] tcg: Search includes from the project root source directory

2019-12-30 Thread Paolo Bonzini
Yes, of course (I thought it would be clear from the message, but perhaps it was a bit implicit). Paolo Il lun 30 dic 2019, 16:48 Philippe Mathieu-Daudé ha scritto: > On Mon, Dec 30, 2019 at 3:02 PM Philippe Mathieu-Daudé > wrote: > > On 12/30/19 11:33 AM, Paolo Bonzini wrote: > > > Il lun 30

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

2019-12-30 Thread Philippe Mathieu-Daudé
On Mon, Dec 30, 2019 at 3:02 PM Philippe Mathieu-Daudé wrote: > On 12/30/19 11:33 AM, Paolo Bonzini wrote: > > Il lun 30 dic 2019, 09:59 Philippe Mathieu-Daudé > > ha scritto: > > > > > I'd prefer not changing those files. > > > > OK, I'll wait to see what Richa

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

2019-12-30 Thread Philippe Mathieu-Daudé
On 12/30/19 11:33 AM, Paolo Bonzini wrote: Il lun 30 dic 2019, 09:59 Philippe Mathieu-Daudé > ha scritto: > I'd prefer not changing those files. OK, I'll wait to see what Richard/Markus prefer. I think it's best if you keep the include directives as-is fo

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

2019-12-30 Thread Paolo Bonzini
Il lun 30 dic 2019, 09:59 Philippe Mathieu-Daudé ha scritto: > > I'd prefer not changing those files. > > OK, I'll wait to see what Richard/Markus prefer. > I think it's best if you keep the include directives as-is for files only needed from tcg/, and move the other headers (those that are need

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

2019-12-30 Thread Philippe Mathieu-Daudé
Hi Stefan, On 12/30/19 10:53 AM, Stefan Weil wrote: Am 30.12.19 um 10:08 schrieb Philippe Mathieu-Daudé: [...] tcg/tcg-op.h | 2 +- tcg/tcg.h | 4 ++-- tcg/tcg-common.c | 2 +- tcg/tcg-op-gvec.c | 8 tcg/tcg-op-vec.c

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

2019-12-30 Thread Stefan Weil
Am 30.12.19 um 10:08 schrieb Philippe Mathieu-Daudé: [...] > tcg/tcg-op.h | 2 +- > tcg/tcg.h | 4 ++-- > tcg/tcg-common.c | 2 +- > tcg/tcg-op-gvec.c | 8 > tcg/tcg-op-vec.c | 6 +++--- > tcg/tcg-op.c

[PATCH 1/2] tcg: Search includes from the project root source directory

2019-12-30 Thread Philippe Mathieu-Daudé
We currently search both the root and the tcg/ directories for tcg files: $ git grep '#include "tcg/' | wc -l 28 $ git grep '#include "tcg[^/]' | wc -l 94 To simplify the preprocessor search path, unify by expliciting the tcg/ directory. Patch created mechanically by running: $ for x