Re: [PATCH 1/2] target/mips: Fold jazz behaviour into mips_cpu_do_transaction_failed

On 2/28/21 12:25 AM, Richard Henderson wrote: > Add a flag to MIPSCPUClass in order to avoid needing to > replace mips_tcg_ops.do_transaction_failed. > > Signed-off-by: Richard Henderson > --- > target/mips/cpu-qom.h | 3 +++ > hw/mips/jazz.c | 35 +++

Re: [PATCH 1/2] target/mips: Fold jazz behaviour into mips_cpu_do_transaction_failed

On 2/28/21 10:39 PM, Richard Henderson wrote: > On 2/28/21 8:14 AM, Philippe Mathieu-Daudé wrote: >>> +/* Used for the jazz board to modify mips_cpu_do_transaction_failed. */ >> >> Isn't it possible to have other (old) boards doing something similar? > > It's possible, but I doubt any need to.

Re: [PATCH 1/2] target/mips: Fold jazz behaviour into mips_cpu_do_transaction_failed

On 2/28/21 8:14 AM, Philippe Mathieu-Daudé wrote: >> +/* Used for the jazz board to modify mips_cpu_do_transaction_failed. */ > > Isn't it possible to have other (old) boards doing something similar? It's possible, but I doubt any need to. I think the comment in hw/mips/jazz.c is correct, in

Re: [PATCH 1/2] target/mips: Fold jazz behaviour into mips_cpu_do_transaction_failed

Hi Richard, On 2/28/21 12:25 AM, Richard Henderson wrote: > Add a flag to MIPSCPUClass in order to avoid needing to > replace mips_tcg_ops.do_transaction_failed. > > Signed-off-by: Richard Henderson > --- > target/mips/cpu-qom.h | 3 +++ > hw/mips/jazz.c | 35 +++

[PATCH 1/2] target/mips: Fold jazz behaviour into mips_cpu_do_transaction_failed

Add a flag to MIPSCPUClass in order to avoid needing to replace mips_tcg_ops.do_transaction_failed. Signed-off-by: Richard Henderson --- target/mips/cpu-qom.h | 3 +++ hw/mips/jazz.c | 35 +++ target/mips/op_helper.c | 3 ++- 3 files changed, 8 insert