Re: [PATCH 1/2] scsi: Add buf_len parameter to scsi_req_new()

2022-08-21 Thread John Millikin
Thank you for the suggestions for CDB sizes! Especially the tricky ones in spapr_vscsi.c and dev-uas.c. v2: https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg02997.html On Fri, Aug 19, 2022 at 06:06:13PM +0200, Paolo Bonzini wrote: > On 8/17/22 07:34, John Millikin wrote: > > The sigil SCS

Re: [PATCH 1/2] scsi: Add buf_len parameter to scsi_req_new()

2022-08-19 Thread Paolo Bonzini
On 8/17/22 07:34, John Millikin wrote: The sigil SCSI_CMD_BUF_LEN_TODO() is used to indicate that the buffer length calculation is TODO it should be replaced by a better value, such as the length of a successful DMA read. Let's just do it right: diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi5

[PATCH 1/2] scsi: Add buf_len parameter to scsi_req_new()

2022-08-16 Thread John Millikin
When a SCSI command is received from the guest, the CDB length implied by the first byte might exceed the number of bytes the guest sent. In this case scsi_req_new() will read uninitialized data, causing unpredictable behavior. Adds the buf_len parameter to scsi_req_new() and plumbs it through the