Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-06-10 Thread Bernhard Beschow
Am 12. Mai 2025 15:32:08 UTC schrieb Paolo Bonzini : >Hi, now that GSoC selection is over I'm back. Sorry for the delay; >Tanish Desai will work mostly on tracing, so logging can remain yours. > >On Tue, Apr 8, 2025 at 10:59 PM Bernhard Beschow wrote: >> >Currently the #defines contain some hol

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-05-20 Thread Paolo Bonzini
On Mon, May 19, 2025 at 10:14 AM Manos Pitsidianakis wrote: > There's also the `tracing` framework > https://docs.rs/tracing/latest/tracing/ that is quite nice for > defining tracing events **and** spans for logs. I find it confusing > that it still ties tracing events with log level filters thoug

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-05-19 Thread Manos Pitsidianakis
Hello Paolo, Bernhard, On Mon, May 12, 2025 at 6:32 PM Paolo Bonzini wrote: > > Hi, now that GSoC selection is over I'm back. Sorry for the delay; > Tanish Desai will work mostly on tracing, so logging can remain yours. > > On Tue, Apr 8, 2025 at 10:59 PM Bernhard Beschow wrote: > > >Currently t

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-05-12 Thread Paolo Bonzini
Hi, now that GSoC selection is over I'm back. Sorry for the delay; Tanish Desai will work mostly on tracing, so logging can remain yours. On Tue, Apr 8, 2025 at 10:59 PM Bernhard Beschow wrote: > >Currently the #defines contain some holes for "private" mask bits. Turning > >these into an > >enum

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-04-08 Thread Bernhard Beschow
Am 1. April 2025 10:51:06 UTC schrieb Bernhard Beschow : > > >Am 31. März 2025 09:53:41 UTC schrieb Paolo Bonzini : >>On 3/30/25 22:58, Bernhard Beschow wrote: >>> A qemu_log_mask!() macro is provided which expects similar arguments as the >>> C >>> version. However, the formatting works as one

[PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-04-05 Thread Bernhard Beschow
A qemu_log_mask!() macro is provided which expects similar arguments as the C version. However, the formatting works as one would expect from Rust. To maximize code reuse the macro is just a thin wrapper around qemu_log(). Also, just the bare minimum of logging masks is provided which should suffi

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-04-01 Thread Bernhard Beschow
Am 31. März 2025 09:53:41 UTC schrieb Paolo Bonzini : >On 3/30/25 22:58, Bernhard Beschow wrote: >> A qemu_log_mask!() macro is provided which expects similar arguments as the C >> version. However, the formatting works as one would expect from Rust. >> >> To maximize code reuse the macro is ju

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-03-31 Thread Paolo Bonzini
On 3/30/25 22:58, Bernhard Beschow wrote: A qemu_log_mask!() macro is provided which expects similar arguments as the C version. However, the formatting works as one would expect from Rust. To maximize code reuse the macro is just a thin wrapper around qemu_log(). Also, just the bare minimum of