Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-23 Thread Gerd Hoffmann
Hi, > >> Migration fails and you want know why. > >> > >> Reason migration fails is the guest violates qxl specs (which doesn't > >> cause actual problems unless you want migrate the guest). > > > > Then I agree error_report() is better ("Report an error to the current > > monitor if we have on

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-23 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/23/21 8:55 AM, Gerd Hoffmann wrote: >> On Fri, Jul 23, 2021 at 08:47:09AM +0200, Philippe Mathieu-Daudé wrote: >>> On 7/23/21 8:32 AM, Gerd Hoffmann wrote: On Thu, Jul 22, 2021 at 03:44:54PM +0100, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-23 Thread Philippe Mathieu-Daudé
On 7/23/21 8:55 AM, Gerd Hoffmann wrote: > On Fri, Jul 23, 2021 at 08:47:09AM +0200, Philippe Mathieu-Daudé wrote: >> On 7/23/21 8:32 AM, Gerd Hoffmann wrote: >>> On Thu, Jul 22, 2021 at 03:44:54PM +0100, Dr. David Alan Gilbert wrote: * Gerd Hoffmann (kra...@redhat.com) wrote: > Since comm

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-22 Thread Gerd Hoffmann
On Fri, Jul 23, 2021 at 08:47:09AM +0200, Philippe Mathieu-Daudé wrote: > On 7/23/21 8:32 AM, Gerd Hoffmann wrote: > > On Thu, Jul 22, 2021 at 03:44:54PM +0100, Dr. David Alan Gilbert wrote: > >> * Gerd Hoffmann (kra...@redhat.com) wrote: > >>> Since commit 551dbd0846d2 ("migration: check pre_save

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-22 Thread Philippe Mathieu-Daudé
On 7/23/21 8:32 AM, Gerd Hoffmann wrote: > On Thu, Jul 22, 2021 at 03:44:54PM +0100, Dr. David Alan Gilbert wrote: >> * Gerd Hoffmann (kra...@redhat.com) wrote: >>> Since commit 551dbd0846d2 ("migration: check pre_save return in >>> vmstate_save_state") the pre_save hook can fail. So lets finally

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-22 Thread Gerd Hoffmann
On Thu, Jul 22, 2021 at 03:44:54PM +0100, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: > > Since commit 551dbd0846d2 ("migration: check pre_save return in > > vmstate_save_state") the pre_save hook can fail. So lets finally > > use that to drop the guest-triggerable a

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-22 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Since commit 551dbd0846d2 ("migration: check pre_save return in > vmstate_save_state") the pre_save hook can fail. So lets finally > use that to drop the guest-triggerable assert in qxl_pre_save(). > > Signed-off-by: Gerd Hoffmann > --- > hw/display/

Re: [PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-21 Thread Marc-André Lureau
On Wed, Jul 21, 2021 at 1:41 PM Gerd Hoffmann wrote: > Since commit 551dbd0846d2 ("migration: check pre_save return in > vmstate_save_state") the pre_save hook can fail. So lets finally > use that to drop the guest-triggerable assert in qxl_pre_save(). > > Signed-off-by: Gerd Hoffmann > Review

[PATCH 1/2] qxl: remove assert in qxl_pre_save.

2021-07-21 Thread Gerd Hoffmann
Since commit 551dbd0846d2 ("migration: check pre_save return in vmstate_save_state") the pre_save hook can fail. So lets finally use that to drop the guest-triggerable assert in qxl_pre_save(). Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deleti