Re: [PATCH 1/2] qapi: introduce forwarding visitor

2021-07-23 Thread Paolo Bonzini
On 22/07/21 17:34, Markus Armbruster wrote: This is not a fifth type of visitor, it's a wrapper for the existing types (two of them, input and output; the other two don't break horribly but make no sense either). Unlike the other visitors, this one isn't of a fixed type. I think mentioning thi

Re: [PATCH 1/2] qapi: introduce forwarding visitor

2021-07-22 Thread Markus Armbruster
Paolo Bonzini writes: > On 22/07/21 16:02, Markus Armbruster wrote: >> Double-checking: the other fields are not accessible via this visitor. >> Correct? > > Correct. > >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> include/qapi/forward-visitor.h| 27 +++ >>> qapi/meson.build

Re: [PATCH 1/2] qapi: introduce forwarding visitor

2021-07-22 Thread Paolo Bonzini
On 22/07/21 16:02, Markus Armbruster wrote: Double-checking: the other fields are not accessible via this visitor. Correct? Correct. Signed-off-by: Paolo Bonzini --- include/qapi/forward-visitor.h| 27 +++ qapi/meson.build | 1 + qapi/qapi-forward-visitor.c

Re: [PATCH 1/2] qapi: introduce forwarding visitor

2021-07-22 Thread Markus Armbruster
Paolo Bonzini writes: > This new adaptor visitor takes a single field of the adaptee, and exposes it > with a different name. > > This will be used for QOM alias properties. Alias targets can of course > have a different name than the alias property itself (e.g. a machine's > pflash0 might be an

Re: [PATCH 1/2] qapi: introduce forwarding visitor

2021-07-19 Thread Eric Blake
On Mon, Jul 19, 2021 at 12:40:32PM +0200, Paolo Bonzini wrote: > This new adaptor visitor takes a single field of the adaptee, and exposes it > with a different name. > > This will be used for QOM alias properties. Alias targets can of course > have a different name than the alias property itself

[PATCH 1/2] qapi: introduce forwarding visitor

2021-07-19 Thread Paolo Bonzini
This new adaptor visitor takes a single field of the adaptee, and exposes it with a different name. This will be used for QOM alias properties. Alias targets can of course have a different name than the alias property itself (e.g. a machine's pflash0 might be an alias of a property named 'drive')