Re: [PATCH 1/2] monitor/hmp: correctly invert password argument detection again

2021-08-25 Thread Marc-André Lureau
Hi On Wed, Aug 25, 2021 at 1:38 PM Stefan Reiter wrote: > Commit cfb5387a1d 'hmp: remove "change vnc TARGET" command' claims to > remove the HMP "change vnc" command, but doesn't actually do that. > Instead if rewires it to use 'qmp_change_vnc_password', and in the > process inverts the argument

[PATCH 1/2] monitor/hmp: correctly invert password argument detection again

2021-08-25 Thread Stefan Reiter
Commit cfb5387a1d 'hmp: remove "change vnc TARGET" command' claims to remove the HMP "change vnc" command, but doesn't actually do that. Instead if rewires it to use 'qmp_change_vnc_password', and in the process inverts the argument detection - ignoring the first issue, this inversion is wrong, as