Re: [PATCH 1/2] migration: Make all helpers in misc.h safe to use without migration

2024-10-23 Thread Peter Xu
On Wed, Oct 23, 2024 at 11:14:24AM -0400, Peter Xu wrote: > On Wed, Oct 23, 2024 at 11:30:14AM +0300, Avihai Horon wrote: > > > > On 22/10/2024 19:07, Peter Xu wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > Migration object can be freed before some other

Re: [PATCH 1/2] migration: Make all helpers in misc.h safe to use without migration

2024-10-23 Thread Peter Xu
On Wed, Oct 23, 2024 at 11:30:14AM +0300, Avihai Horon wrote: > > On 22/10/2024 19:07, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > Migration object can be freed before some other device codes run, while we > > do have a bunch of migration helpers expo

Re: [PATCH 1/2] migration: Make all helpers in misc.h safe to use without migration

2024-10-23 Thread Avihai Horon
On 22/10/2024 19:07, Peter Xu wrote: External email: Use caution opening links or attachments Migration object can be freed before some other device codes run, while we do have a bunch of migration helpers exported in migration/misc.h that logically can be invoked at any time of QEMU, even du

Re: [PATCH 1/2] migration: Make all helpers in misc.h safe to use without migration

2024-10-22 Thread Peter Xu
On Tue, Oct 22, 2024 at 06:11:19PM +0200, Cédric Le Goater wrote: > On 10/22/24 18:07, Peter Xu wrote: > > Migration object can be freed before some other device codes run, while we > > do have a bunch of migration helpers exported in migration/misc.h that > > logically can be invoked at any time o

Re: [PATCH 1/2] migration: Make all helpers in misc.h safe to use without migration

2024-10-22 Thread Cédric Le Goater
On 10/22/24 18:07, Peter Xu wrote: Migration object can be freed before some other device codes run, while we do have a bunch of migration helpers exported in migration/misc.h that logically can be invoked at any time of QEMU, even during destruction of a VM. Make all these functions safe to be

[PATCH 1/2] migration: Make all helpers in misc.h safe to use without migration

2024-10-22 Thread Peter Xu
Migration object can be freed before some other device codes run, while we do have a bunch of migration helpers exported in migration/misc.h that logically can be invoked at any time of QEMU, even during destruction of a VM. Make all these functions safe to be called, especially, not crashing afte