Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-04-05 Thread Prasad Pandit
On Thu, 20 Mar 2025 at 20:15, Fabiano Rosas wrote: > Technically both can happen. But that would just be the case of > file:fdset migration which requires an extra fd for O_DIRECT. So > "multiple" in the usual sense of "more is better" is only > fd-per-thread. IOW, using multiple fds is an impleme

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-04-05 Thread Fabiano Rosas
Prasad Pandit writes: > On Thu, 20 Mar 2025 at 20:15, Fabiano Rosas wrote: >> Technically both can happen. But that would just be the case of >> file:fdset migration which requires an extra fd for O_DIRECT. So >> "multiple" in the usual sense of "more is better" is only >> fd-per-thread. IOW, us

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-04-04 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Mar 20, 2025 at 11:45:29AM -0300, Fabiano Rosas wrote: >> There's a bunch of other issues as well: >> >> - no clear distinction between what should go in the header and what >> should go in the packet. >> >> - the header taking up one slot in the iov, which should i

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-24 Thread Prasad Pandit
Hi, On Fri, 21 Mar 2025 at 19:34, Fabiano Rosas wrote: > Well, I can't speak for everyone, of course, but generally the less > layers on top of the object of your work the better. * Yes, true. > There are several ways of accessing QMP, some examples I have lying > around: > > == > $QEMU ... -

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-20 Thread Fabiano Rosas
Prasad Pandit writes: > On Tue, 11 Mar 2025 at 00:59, Fabiano Rosas wrote: >> Peter Xu writes: >> > To me, this is a fairly important question to ask. Fundamentally, the very >> > initial question is why do we need periodic flush and sync at all. It's >> > because we want to make sure new ver

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-20 Thread Peter Xu
On Thu, Mar 20, 2025 at 11:45:29AM -0300, Fabiano Rosas wrote: > There's a bunch of other issues as well: > > - no clear distinction between what should go in the header and what > should go in the packet. > > - the header taking up one slot in the iov, which should in theory be > responsibil

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-20 Thread Fabiano Rosas
Prasad Pandit writes: > Hello Fabiano, > > * First big thank you for starting/writing this document. It is a > great resource. > > On Fri, 7 Mar 2025 at 19:13, Fabiano Rosas wrote: >> +++ b/docs/devel/migration/multifd.rst >> @@ -0,0 +1,254 @@ >> +Multifd >> +Multifd is the name given for the mi

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-20 Thread Prasad Pandit
On Tue, 11 Mar 2025 at 00:59, Fabiano Rosas wrote: > Peter Xu writes: > > To me, this is a fairly important question to ask. Fundamentally, the very > > initial question is why do we need periodic flush and sync at all. It's > > because we want to make sure new version of pages to land later th

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-20 Thread Prasad Pandit
Hello Fabiano, * First big thank you for starting/writing this document. It is a great resource. On Fri, 7 Mar 2025 at 19:13, Fabiano Rosas wrote: > +++ b/docs/devel/migration/multifd.rst > @@ -0,0 +1,254 @@ > +Multifd > +Multifd is the name given for the migration capability that enables > +dat

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-11 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Mar 07, 2025 at 04:06:17PM -0300, Fabiano Rosas wrote: >> > I never tried vsock, would it be used in any use case? >> > >> >> I don't know, I'm going by what's in the code. >> >> > It seems to be introduced by accident in 72a8192e225cea, but I'm not sure. >> > Maybe t

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-11 Thread Peter Xu
On Mon, Mar 10, 2025 at 11:24:15AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Fri, Mar 07, 2025 at 04:06:17PM -0300, Fabiano Rosas wrote: > >> > I never tried vsock, would it be used in any use case? > >> > > >> > >> I don't know, I'm going by what's in the code. > >> > >> > It see

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-11 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Mar 10, 2025 at 11:24:15AM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Fri, Mar 07, 2025 at 04:06:17PM -0300, Fabiano Rosas wrote: >> >> > I never tried vsock, would it be used in any use case? >> >> > >> >> >> >> I don't know, I'm going by what's in t

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-08 Thread Peter Xu
On Fri, Mar 07, 2025 at 10:42:02AM -0300, Fabiano Rosas wrote: > There's currently no documentation for multifd, we can at least > provide an overview of the feature. We missed this for a long time indeed.. > > Signed-off-by: Fabiano Rosas > --- > Keep in mind the feature grew organically over

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-07 Thread Peter Xu
On Fri, Mar 07, 2025 at 04:06:17PM -0300, Fabiano Rosas wrote: > > I never tried vsock, would it be used in any use case? > > > > I don't know, I'm going by what's in the code. > > > It seems to be introduced by accident in 72a8192e225cea, but I'm not sure. > > Maybe there's something I missed. >

Re: [PATCH 1/2] migration: Add some documentation for multifd

2025-03-07 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Mar 07, 2025 at 10:42:02AM -0300, Fabiano Rosas wrote: >> There's currently no documentation for multifd, we can at least >> provide an overview of the feature. > > We missed this for a long time indeed.. > >> >> Signed-off-by: Fabiano Rosas >> --- >> Keep in mind the

[PATCH 1/2] migration: Add some documentation for multifd

2025-03-07 Thread Fabiano Rosas
There's currently no documentation for multifd, we can at least provide an overview of the feature. Signed-off-by: Fabiano Rosas --- Keep in mind the feature grew organically over the years and it has had bugs that required reinventing some concepts, specially on the sync part, so there's still s