Re: [PATCH 1/2] migration/colo: Optimize COLO start code path

2021-11-17 Thread Juan Quintela
"Zhang, Chen" wrote: >> -Original Message- >> From: Juan Quintela >> Sent: Wednesday, November 17, 2021 12:28 AM >> To: Zhang, Chen >> Cc: Hailiang Zhang ; Dr . David Alan >> Gilbert ; qemu-dev >> Subject: Re: [PATCH 1/2] migration/c

RE: [PATCH 1/2] migration/colo: Optimize COLO start code path

2021-11-16 Thread Zhang, Chen
> -Original Message- > From: Juan Quintela > Sent: Wednesday, November 17, 2021 12:28 AM > To: Zhang, Chen > Cc: Hailiang Zhang ; Dr . David Alan > Gilbert ; qemu-dev > Subject: Re: [PATCH 1/2] migration/colo: Optimize COLO start code path > > Zhang Chen

Re: [PATCH 1/2] migration/colo: Optimize COLO start code path

2021-11-16 Thread Juan Quintela
Zhang Chen wrote: > There is no need to start COLO through MIGRATION_STATUS_ACTIVE. Hi I don't understand what you are trying to do. In my reading, at least the commit message is wrong: void migrate_start_colo_process(MigrationState *s) { ... migrate_set_state(&s->state, MIGRATION_STAT

[PATCH 1/2] migration/colo: Optimize COLO start code path

2021-11-10 Thread Zhang Chen
There is no need to start COLO through MIGRATION_STATUS_ACTIVE. Signed-off-by: Zhang Chen --- migration/colo.c | 2 -- migration/migration.c | 18 +++--- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index 2415325262..ad1a44