Re: [PATCH 1/2] hw/virtio/vhost-user: don't use uninitialized variable

2022-06-02 Thread Alex Bennée
"Liu, Changpeng" writes: >> -Original Message- >> From: Alex Bennée >> Sent: Tuesday, May 31, 2022 10:46 PM >> To: Liu, Changpeng >> Cc: qemu-devel@nongnu.org >> Subject: Re: [PATCH 1/2] hw/virtio/vhost-user: don't use uninitia

RE: [PATCH 1/2] hw/virtio/vhost-user: don't use uninitialized variable

2022-05-31 Thread Liu, Changpeng
> -Original Message- > From: Alex Bennée > Sent: Tuesday, May 31, 2022 10:46 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH 1/2] hw/virtio/vhost-user: don't use uninitialized > variable > > > Changpeng Liu writes

Re: [PATCH 1/2] hw/virtio/vhost-user: don't use uninitialized variable

2022-05-31 Thread Alex Bennée
Changpeng Liu writes: > Variable `vdev` in `struct vhost_dev` will not be ready > until start the device, so let's not use it for the error > output here. This seems to be one of the areas where vhost_user_backend_dev_init and vhost_dev_init do things differently. Is there any particular reaso

Re: [PATCH 1/2] hw/virtio/vhost-user: don't use uninitialized variable

2022-05-30 Thread Raphael Norwitz
On Wed, May 25, 2022 at 08:55:39PM +0800, Changpeng Liu wrote: > Variable `vdev` in `struct vhost_dev` will not be ready > until start the device, so let's not use it for the error > output here. > > Fixes: 5653493 ("hw/virtio/vhost-user: don't suppress F_CONFIG when > supported") > > Signed-off

[PATCH 1/2] hw/virtio/vhost-user: don't use uninitialized variable

2022-05-25 Thread Changpeng Liu
Variable `vdev` in `struct vhost_dev` will not be ready until start the device, so let's not use it for the error output here. Fixes: 5653493 ("hw/virtio/vhost-user: don't suppress F_CONFIG when supported") Signed-off-by: Changpeng Liu --- hw/virtio/vhost-user.c | 8 +++- 1 file changed, 3