Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC

2020-06-02 Thread Eric Blake
On 4/20/20 5:07 PM, Eduardo Habkost wrote: On Mon, Apr 20, 2020 at 12:53:07PM -0500, Eric Blake wrote: Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in 32-bit mode

Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC

2020-04-20 Thread Colin Xu
Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Tue, 21 Apr 2020, Eric Blake wrote: Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in 32-bi

Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC

2020-04-20 Thread Eduardo Habkost
On Mon, Apr 20, 2020 at 12:53:07PM -0500, Eric Blake wrote: > Blindly setting FD_CLOEXEC without a read-modify-write will > inadvertently clear any other intentionally-set bits, such as a > proposed new bit for designating a fd that must behave in 32-bit mode. > Use our wrapper function instead of

[PATCH 1/2] hax: Fix setting of FD_CLOEXEC

2020-04-20 Thread Eric Blake
Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in 32-bit mode. Use our wrapper function instead of an incorrect hand-rolled version. Signed-off-by: Eric Blake --- t