Re: [PATCH 1/2] Consistent function names for sifive uart read and write function

Hi Lukas, On Wed, May 5, 2021 at 12:49 AM Lukas Jünger wrote: > While we are here, could we make other functions sifive_ prefixed? Also the commit title should include a tag of "hw/char: sifive_uart" > Signed-off-by: Lukas Jünger > --- > hw/char/sifive_uart.c | 14 +++--- > 1 file ch

Re: [PATCH 1/2] Consistent function names for sifive uart read and write function

On 5/4/21 5:34 PM, Lukas Jünger wrote: Signed-off-by: Lukas Jünger Reviewed-by: Luc Michel --- hw/char/sifive_uart.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 3a00ba7f00..cb70374ead 100644 --- a/

Re: [PATCH 1/2] Consistent function names for sifive uart read and write function

On Wed, May 5, 2021 at 2:50 AM Lukas Jünger wrote: > > Signed-off-by: Lukas Jünger Reviewed-by: Alistair Francis Alistair > --- > hw/char/sifive_uart.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c > inde

[PATCH 1/2] Consistent function names for sifive uart read and write function

Signed-off-by: Lukas Jünger --- hw/char/sifive_uart.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 3a00ba7f00..cb70374ead 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -65,7 +65,7 @@ stat