Re: [PATCH 1/1] vl.c: do not execute trace_init_backends() before daemonizing

2021-01-05 Thread Daniel Henrique Barboza
On 1/5/21 3:09 PM, Paolo Bonzini wrote: On 05/01/21 19:03, Daniel Henrique Barboza wrote: +    /* + * The trace backend must be initialized before daemonizing. after, not before. :) hahaha messed up in the comment block. Typical. With this fixed, Reviewed-by: Paolo Bonzini Th

[PATCH 1/1] vl.c: do not execute trace_init_backends() before daemonizing

2021-01-05 Thread Daniel Henrique Barboza
Commit v5.2.0-190-g0546c0609c ("vl: split various early command line options to a separate function") moved the trace backend init code to the qemu_process_early_options(). Which is now being called before os_daemonize() via qemu_maybe_daemonize(). Turns out that this change of order causes a prob

Re: [PATCH 1/1] vl.c: do not execute trace_init_backends() before daemonizing

2021-01-05 Thread Paolo Bonzini
On 05/01/21 19:03, Daniel Henrique Barboza wrote: +/* + * The trace backend must be initialized before daemonizing. after, not before. :) With this fixed, Reviewed-by: Paolo Bonzini + * trace_init_backends() will call st_init(), which will create the + * trace thread in the