Re: [PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-03-04 Thread Halil Pasic
On Fri, 4 Mar 2022 03:12:03 -0500 "Michael S. Tsirkin" wrote: > On Thu, Feb 10, 2022 at 02:29:29PM +0100, Halil Pasic wrote: > > On Thu, 10 Feb 2022 12:19:25 +0100 > > Cornelia Huck wrote: > > > > [..] > > > > > > Nope, that's not my problem. We make sure that the bit is persistent, we > > >

Re: [PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-03-04 Thread Michael S. Tsirkin
On Thu, Feb 10, 2022 at 02:29:29PM +0100, Halil Pasic wrote: > On Thu, 10 Feb 2022 12:19:25 +0100 > Cornelia Huck wrote: > > [..] > > > > Nope, that's not my problem. We make sure that the bit is persistent, we > > fail realization if the bit got removed by the callback when required, > > and we

Re: [PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-10 Thread Halil Pasic
On Thu, 10 Feb 2022 12:19:25 +0100 Cornelia Huck wrote: [..] > > Nope, that's not my problem. We make sure that the bit is persistent, we > fail realization if the bit got removed by the callback when required, > and we fail feature validation if the driver removes the bit, which is > in a diffe

Re: [PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-10 Thread Cornelia Huck
On Thu, Feb 10 2022, Halil Pasic wrote: > On Thu, 10 Feb 2022 10:55:13 +0100 > Cornelia Huck wrote: > >> On Wed, Feb 09 2022, Halil Pasic wrote: >> >> > On Wed, 09 Feb 2022 18:24:56 +0100 >> > Cornelia Huck wrote: >> > >> >> On Wed, Feb 09 2022, Halil Pasic wrote: >> >> > @@ -78,16 +78,1

Re: [PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-10 Thread Halil Pasic
On Thu, 10 Feb 2022 10:55:13 +0100 Cornelia Huck wrote: > On Wed, Feb 09 2022, Halil Pasic wrote: > > > On Wed, 09 Feb 2022 18:24:56 +0100 > > Cornelia Huck wrote: > > > >> On Wed, Feb 09 2022, Halil Pasic wrote: > >> > @@ -78,16 +78,19 @@ void virtio_bus_device_plugged(VirtIODevice *vdev

Re: [PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-10 Thread Cornelia Huck
On Wed, Feb 09 2022, Halil Pasic wrote: > On Wed, 09 Feb 2022 18:24:56 +0100 > Cornelia Huck wrote: > >> On Wed, Feb 09 2022, Halil Pasic wrote: >> > @@ -78,16 +78,19 @@ void virtio_bus_device_plugged(VirtIODevice *vdev, >> > Error **errp) >> > return; >> > } >> > >> > -vde

Re: [PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-09 Thread Halil Pasic
On Wed, 09 Feb 2022 18:24:56 +0100 Cornelia Huck wrote: > On Wed, Feb 09 2022, Halil Pasic wrote: > > > Unlike most virtio features ACCESS_PLATFORM is considered mandatory by > > QEMU, i.e. the driver must accept it if offered by the device. The > > virtio specification says that the driver SHO

Re: [PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-09 Thread Cornelia Huck
On Wed, Feb 09 2022, Halil Pasic wrote: > Unlike most virtio features ACCESS_PLATFORM is considered mandatory by > QEMU, i.e. the driver must accept it if offered by the device. The > virtio specification says that the driver SHOULD accept the > ACCESS_PLATFORM feature if offered, and that the de

[PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-09 Thread Halil Pasic
Unlike most virtio features ACCESS_PLATFORM is considered mandatory by QEMU, i.e. the driver must accept it if offered by the device. The virtio specification says that the driver SHOULD accept the ACCESS_PLATFORM feature if offered, and that the device MAY fail to operate if ACCESS_PLATFORM was of

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Halil Pasic
On Mon, 7 Feb 2022 16:46:04 -0300 Daniel Henrique Barboza wrote: > On 2/7/22 11:46, Halil Pasic wrote: > > On Mon, 7 Feb 2022 08:46:34 -0300 > > Daniel Henrique Barboza wrote: > > > > I have considered this and decided against it. The reason why is > > if that approach is taken, we can't real

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Daniel Henrique Barboza
On 2/7/22 11:46, Halil Pasic wrote: On Mon, 7 Feb 2022 08:46:34 -0300 Daniel Henrique Barboza wrote: On 2/3/22 13:45, Halil Pasic wrote: Unlike most virtio features ACCESS_PATFORM is considered mandatory, i.e. the driver must accept it if offered by the device. The virtio specification say

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Michael S. Tsirkin
On Mon, Feb 07, 2022 at 04:05:16PM +0100, Halil Pasic wrote: > On Mon, 07 Feb 2022 14:41:58 +0100 > Cornelia Huck wrote: > > > On Mon, Feb 07 2022, Daniel Henrique Barboza wrote: > > > > > On 2/3/22 13:45, Halil Pasic wrote: > > >> Unlike most virtio features ACCESS_PATFORM is considered mand

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Halil Pasic
On Mon, 07 Feb 2022 16:21:31 +0100 Cornelia Huck wrote: > On Mon, Feb 07 2022, Halil Pasic wrote: > > > On Mon, 07 Feb 2022 14:41:58 +0100 > > Cornelia Huck wrote: > > >> OTOH, the decision to make it mandatory is certainly sound, and covered > >> by the spec. As the driver must be prepared

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Cornelia Huck
On Mon, Feb 07 2022, Halil Pasic wrote: > On Mon, 07 Feb 2022 14:41:58 +0100 > Cornelia Huck wrote: >> OTOH, the decision to make it mandatory is certainly sound, and covered >> by the spec. As the driver must be prepared for the device failing to >> accept FEATURES_OK, we can make it mandatory

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Halil Pasic
On Mon, 07 Feb 2022 14:41:58 +0100 Cornelia Huck wrote: > On Mon, Feb 07 2022, Daniel Henrique Barboza wrote: > > > On 2/3/22 13:45, Halil Pasic wrote: > >> Unlike most virtio features ACCESS_PATFORM is considered mandatory, i.e. > > s/ACCESS_PATFORM/ACCESS_PLATFORM/ Will fix. > > >> th

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Halil Pasic
On Mon, 7 Feb 2022 08:46:34 -0300 Daniel Henrique Barboza wrote: > On 2/3/22 13:45, Halil Pasic wrote: > > Unlike most virtio features ACCESS_PATFORM is considered mandatory, i.e. > > the driver must accept it if offered by the device. The virtio > > specification says that the driver SHOULD acce

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Daniel Henrique Barboza
On 2/7/22 10:41, Cornelia Huck wrote: On Mon, Feb 07 2022, Daniel Henrique Barboza wrote: On 2/3/22 13:45, Halil Pasic wrote: Unlike most virtio features ACCESS_PATFORM is considered mandatory, i.e. s/ACCESS_PATFORM/ACCESS_PLATFORM/ the driver must accept it if offered by the device. T

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Cornelia Huck
On Mon, Feb 07 2022, Daniel Henrique Barboza wrote: > On 2/3/22 13:45, Halil Pasic wrote: >> Unlike most virtio features ACCESS_PATFORM is considered mandatory, i.e. s/ACCESS_PATFORM/ACCESS_PLATFORM/ >> the driver must accept it if offered by the device. The virtio >> specification says that th

Re: [RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-07 Thread Daniel Henrique Barboza
On 2/3/22 13:45, Halil Pasic wrote: Unlike most virtio features ACCESS_PATFORM is considered mandatory, i.e. the driver must accept it if offered by the device. The virtio specification says that the driver SHOULD accept the ACCESS_PLATFORM feature if offered, and that the device MAY fail to o

[RFC PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-03 Thread Halil Pasic
Unlike most virtio features ACCESS_PATFORM is considered mandatory, i.e. the driver must accept it if offered by the device. The virtio specification says that the driver SHOULD accept the ACCESS_PLATFORM feature if offered, and that the device MAY fail to operate if ACCESS_PLATFORM was offered but