On Tue, 29 Oct 2024 at 20:47, wrote:
> >Our coding style for multiline comments says
> >/*
> > * they look like this, with the opening and closing markers on
> > * lines of their own
> > */
>
> I will changed that.
>
> It do not seem to be followed in In hw/intc/armv7m_nvic.c, but my new comment
Hi Peter,
>On Tue, 22 Oct 2024 at 21:34, Matthieu Castet wrote:
>>
>> Signed-off-by: Matthieu Castet
>
>Hi; thanks for this patch. I have some initial code review comments,
>but the change looks broadly correct to me and I don't think
>there's anything obvious missing.
>
>The commit message body
On Tue, 22 Oct 2024 at 21:34, Matthieu Castet wrote:
>
> Signed-off-by: Matthieu Castet
Hi; thanks for this patch. I have some initial code review comments,
but the change looks broadly correct to me and I don't think
there's anything obvious missing.
The commit message body here is empty. Commi
Signed-off-by: Matthieu Castet
---
hw/intc/armv7m_nvic.c| 38 +-
target/arm/cpu.c | 4 ++--
target/arm/ptw.c | 23 +++
target/arm/tcg/cpu-v7m.c | 21 -
4 files changed, 74 insertions(+), 12 deletions(-
cores"
, "open list:All patches CC here"
Envoyé: Mardi 22 Octobre 2024 22:03:10
Objet: [PATCH 1/1] target/arm: Add cortex-m0+ support
Signed-off-by: Matthieu Castet
---
hw/intc/armv7m_nvic.c | 38 +-
target/arm/cpu.c | 4 ++--
target/arm/ptw.c
Signed-off-by: Matthieu Castet
---
hw/intc/armv7m_nvic.c| 38 +-
target/arm/cpu.c | 4 ++--
target/arm/ptw.c | 23 +++
target/arm/tcg/cpu-v7m.c | 21 -
4 files changed, 74 insertions(+), 12 deletions(-
