Re: [PATCH 1/1] plugins: add API to read guest CPU memory from hwaddr

2025-01-09 Thread Alex Bennée
Rowan Hart writes: Apologies for the delay, I realise this has been sitting on my review queue too long. > Signed-off-by: Rowan Hart > --- > include/qemu/qemu-plugin.h | 22 ++ > plugins/api.c| 17 + > plugins/qemu-plugins.symbols | 2 ++ >

Re: [PATCH 1/1] plugins: add API to read guest CPU memory from hwaddr

2024-08-30 Thread Pierrick Bouvier
And by the way, feel free to integrate this with your other series (as it's a very similar topic) in a v3, so we can review both at the same time. Thanks, Pierrick On 8/30/24 12:30, Pierrick Bouvier wrote: Hi Rowan, thanks for this good complement on the virt address read function. However,

Re: [PATCH 1/1] plugins: add API to read guest CPU memory from hwaddr

2024-08-30 Thread Pierrick Bouvier
Hi Rowan, thanks for this good complement on the virt address read function. However, to be able to merge a new plugins API function, we must have a concrete usage of it, through one of the existing plugin. What could be a good demonstration of value brought by being able to read a physical ad

Re: [PATCH 1/1] plugins: add API to read guest CPU memory from hwaddr

2024-08-28 Thread Rowan Hart
> + qemu_plugin_read_cpu_memory_hwaddr; > + qemu_plugin_read_io_memory_hwaddr; This second symbol name should be removed, I initially wanted to implement for IO as well but there is no good generic way I can see to access a list of IO AddressSpace to read from.

[PATCH 1/1] plugins: add API to read guest CPU memory from hwaddr

2024-08-27 Thread Rowan Hart
Signed-off-by: Rowan Hart --- include/qemu/qemu-plugin.h | 22 ++ plugins/api.c| 17 + plugins/qemu-plugins.symbols | 2 ++ 3 files changed, 41 insertions(+) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index c71c705b