Re: [PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

Le 09/01/2021 à 19:59, Stefan a écrit : > The sizeof(struct ifreq) is 40 for 64 bit and 32 for 32 bit architectures. > This structure contains a union of other structures, of which struct ifmap > is the biggest for 64 bit architectures. Calling ioclt(…, SIOCGIFCONF, …) > fills a struct sockaddr of

Re: [PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

Le 09/01/2021 à 19:59, Stefan a écrit : > The sizeof(struct ifreq) is 40 for 64 bit and 32 for 32 bit architectures. > This structure contains a union of other structures, of which struct ifmap > is the biggest for 64 bit architectures. Calling ioclt(…, SIOCGIFCONF, …) > fills a struct sockaddr of

Re: [PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

ping http://patchwork.ozlabs.org/project/qemu-devel/patch/60aa0765-53dd-43d1-a3d2-75f177852...@vodafonemail.de/#2615112 Hi! I’d like to remind you to this trivial patch to get ioclt(…, SIOCGIFCONF, …) working properly on 64 bit target architectures. Bye Stefan

Re: [PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

Hi Laurent! Thanks for your response. > Why don't you simply replace STRUCT_sockaddr_ifreq by STRUCT_ifmap_ifreq > rather than introducing a > new constant? Because STRUCT_sockaddr_ifreq is the union part to be filled and is needed as an argument to thunk_convert() in this loop below:

Re: [PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

Le 09/01/2021 à 19:59, Stefan a écrit : > The sizeof(struct ifreq) is 40 for 64 bit and 32 for 32 bit architectures. > This structure contains a union of other structures, of which struct ifmap > is the biggest for 64 bit architectures. Calling ioclt(…, SIOCGIFCONF, …) > fills a struct sockaddr of

Re: [PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

pinghttp://patchwork.ozlabs.org/project/qemu-devel/patch/60aa0765-53dd-43d1-a3d2-75f177852...@vodafonemail.de/ Hi!I’d like to remind you to this trivial patch to get ioclt(…, SIOCGIFCONF, …) working properly on 64 bit target architectures.ByeStefan

Re: [PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

ping http://patchwork.ozlabs.org/project/qemu-devel/patch/60aa0765-53dd-43d1-a3d2-75f177852...@vodafonemail.de/ Hi! I’d like to remind you to this trivial patch to get ioclt(…, SIOCGIFCONF, …) working properly on 64 bit target architectures. Bye Stefan

[PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

The sizeof(struct ifreq) is 40 for 64 bit and 32 for 32 bit architectures. This structure contains a union of other structures, of which struct ifmap is the biggest for 64 bit architectures. Calling ioclt(…, SIOCGIFCONF, …) fills a struct sockaddr of that union, and do_ioctl_ifconf() only considere