Re: [PATCH 1/1] hw/riscv/virt.c: move create_fw_cfg() back to virt_machine_init()

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 11:28 PM Daniel Henrique Barboza wrote: > > Commit 1c20d3ff6004 ("hw/riscv: virt: Add a machine done notifier") > moved the initialization of fw_cfg to the virt_machine_done() callback. > > Problem is that the validation of fw_cfg by devices such as ramfb is > done before t

Re: [PATCH 1/1] hw/riscv/virt.c: move create_fw_cfg() back to virt_machine_init()

2023-01-18 Thread Alistair Francis
On Tue, Jan 17, 2023 at 11:28 PM Daniel Henrique Barboza wrote: > > Commit 1c20d3ff6004 ("hw/riscv: virt: Add a machine done notifier") > moved the initialization of fw_cfg to the virt_machine_done() callback. > > Problem is that the validation of fw_cfg by devices such as ramfb is > done before t

[PATCH 1/1] hw/riscv/virt.c: move create_fw_cfg() back to virt_machine_init()

2023-01-17 Thread Daniel Henrique Barboza
Commit 1c20d3ff6004 ("hw/riscv: virt: Add a machine done notifier") moved the initialization of fw_cfg to the virt_machine_done() callback. Problem is that the validation of fw_cfg by devices such as ramfb is done before the machine done notifier is called. Moving create_fw_cfg() to machine_done()