Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

2021-10-27 Thread Daniel P . Berrangé
On Wed, Oct 27, 2021 at 01:35:25PM +0200, Gerd Hoffmann wrote: > Hi, > > > This scenario a tricky problem, and I'm not seeing an easy answer to it > > so far. > > Only exclude stable branches? The stable branches issue is just one of the bugs - the bigger bug is that we're publishing container

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

2021-10-27 Thread Gerd Hoffmann
Hi, > This scenario a tricky problem, and I'm not seeing an easy answer to it > so far. Only exclude stable branches? take care, Gerd

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

2021-10-27 Thread Philippe Mathieu-Daudé
Hi Thomas, On 10/27/21 08:01, Thomas Huth wrote: > On 26/10/2021 16.55, Philippe Mathieu-Daudé wrote: >> Users expect images pulled from registry.gitlab.com/qemu-project/qemu/ >> to be stable. QEMU repository workflow pushes merge candidates to >> the /staging branch, and on success the same commi

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

2021-10-27 Thread Daniel P . Berrangé
On Wed, Oct 27, 2021 at 08:01:07AM +0200, Thomas Huth wrote: > On 26/10/2021 16.55, Philippe Mathieu-Daudé wrote: > > Users expect images pulled from registry.gitlab.com/qemu-project/qemu/ > > to be stable. QEMU repository workflow pushes merge candidates to > > the /staging branch, and on success

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

2021-10-26 Thread Thomas Huth
On 26/10/2021 16.55, Philippe Mathieu-Daudé wrote: Users expect images pulled from registry.gitlab.com/qemu-project/qemu/ to be stable. QEMU repository workflow pushes merge candidates to the /staging branch, and on success the same commit is pushed as /master. If /staging fails, we do not want t

Re: [PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

2021-10-26 Thread Willian Rampazzo
On Tue, Oct 26, 2021 at 11:55 AM Philippe Mathieu-Daudé wrote: > > Users expect images pulled from registry.gitlab.com/qemu-project/qemu/ > to be stable. QEMU repository workflow pushes merge candidates to > the /staging branch, and on success the same commit is pushed as > /master. If /staging fa

[PATCH 1/1] gitlab-ci: Only push docker images to registry from /master branch

2021-10-26 Thread Philippe Mathieu-Daudé
Users expect images pulled from registry.gitlab.com/qemu-project/qemu/ to be stable. QEMU repository workflow pushes merge candidates to the /staging branch, and on success the same commit is pushed as /master. If /staging fails, we do not want to push the built images to the registry. Therefore li