Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

2021-02-03 Thread Stefan Hajnoczi
On Wed, Feb 03, 2021 at 01:29:03PM +0300, Denis V. Lunev wrote: > On 2/3/21 2:08 AM, Eric Blake wrote: > > On 2/2/21 4:50 PM, Denis V. Lunev wrote: > >> On 2/3/21 1:15 AM, Eric Blake wrote: > >>> On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > 28.01.2021 20:13, Denis V. Lunev wrote:

Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

2021-02-03 Thread Denis V. Lunev
On 2/3/21 2:08 AM, Eric Blake wrote: > On 2/2/21 4:50 PM, Denis V. Lunev wrote: >> On 2/3/21 1:15 AM, Eric Blake wrote: >>> On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: 28.01.2021 20:13, Denis V. Lunev wrote: > Original specification says that l1 table size if 64 * l1_size, whi

Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

2021-02-02 Thread Denis V. Lunev
On 2/3/21 1:15 AM, Eric Blake wrote: > On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: >> 28.01.2021 20:13, Denis V. Lunev wrote: >>> Original specification says that l1 table size if 64 * l1_size, which >>> is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. >>> Thus 64

Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

2021-02-02 Thread Eric Blake
On 2/2/21 4:50 PM, Denis V. Lunev wrote: > On 2/3/21 1:15 AM, Eric Blake wrote: >> On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 28.01.2021 20:13, Denis V. Lunev wrote: Original specification says that l1 table size if 64 * l1_size, which is obviously wrong. The size of the

Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

2021-02-02 Thread Eric Blake
On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > 28.01.2021 20:13, Denis V. Lunev wrote: >> Original specification says that l1 table size if 64 * l1_size, which >> is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. >> Thus 64 is to be replaces with 8 as specification s

Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

2021-01-28 Thread Vladimir Sementsov-Ogievskiy
28.01.2021 20:13, Denis V. Lunev wrote: Original specification says that l1 table size if 64 * l1_size, which is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. Thus 64 is to be replaces with 8 as specification says about bytes. There is also minor tweak, field name is renamed

[PATCH 1/1] docs: fix mistake in dirty bitmap feature description

2021-01-28 Thread Denis V. Lunev
Original specification says that l1 table size if 64 * l1_size, which is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. Thus 64 is to be replaces with 8 as specification says about bytes. There is also minor tweak, field name is renamed from l1 to l1_table, which matches with t