Re: [PATCH 1/1] allow using a higher icount

👍 On Fri, Sep 13, 2024, 13:06 Alex Bennée wrote: > Elisha Hollander writes: > > > weird... > > Richard has posted some patches: > > Message-ID: <20240910212351.977753-1-richard.hender...@linaro.org> > Date: Tue, 10 Sep 2024 14:23:49 -0700 > Subject: [PATCH 0/2] tcg: Fix branch/label link

Re: [PATCH 1/1] allow using a higher icount

{ "emoji": "👍", "version": 1 }

Re: [PATCH 1/1] allow using a higher icount

Elisha Hollander writes: > weird... Richard has posted some patches: Message-ID: <20240910212351.977753-1-richard.hender...@linaro.org> Date: Tue, 10 Sep 2024 14:23:49 -0700 Subject: [PATCH 0/2] tcg: Fix branch/label link during plugin expansion From: Richard Henderson which work for

Re: [PATCH 1/1] allow using a higher icount

weird... On Tue, Sep 3, 2024, 14:13 Alex Bennée wrote: > Alex Bennée writes: > > > Elisha Hollander writes: > > > >> Sure! > >> > >> `build/qemu-system-i386 -plugin build/contrib/plugins/libips.so,ips=1 > -display curses -bios bios.raw` > >> > >> Also, I just tested with 9.1.0-rc4 and it resul

Re: [PATCH 1/1] allow using a higher icount

Elisha Hollander writes: > Sure! > > `build/qemu-system-i386 -plugin build/contrib/plugins/libips.so,ips=1 > -display curses -bios bios.raw` > > Also, I just tested with 9.1.0-rc4 and it resulted with > `tcg.c:3167:remove_label_use: code should not be reached` I can replicate but it seems to be

Re: [PATCH 1/1] allow using a higher icount

Alex Bennée writes: > Elisha Hollander writes: > >> Sure! >> >> `build/qemu-system-i386 -plugin build/contrib/plugins/libips.so,ips=1 >> -display curses -bios bios.raw` >> >> Also, I just tested with 9.1.0-rc4 and it resulted with >> `tcg.c:3167:remove_label_use: code should not be reached` > >

Re: [PATCH 1/1] allow using a higher icount

Sure! `build/qemu-system-i386 -plugin build/contrib/plugins/libips.so,ips=1 -display curses -bios bios.raw` Also, I just tested with 9.1.0-rc4 and it resulted with `tcg.c:3167:remove_label_use: code should not be reached` On Mon, Sep 2, 2024, 16:08 Alex Bennée wrote: > Elisha Hollander writes

Re: [PATCH 1/1] allow using a higher icount

Elisha Hollander writes: > But for qemu_plugin_update_ns > > On Mon, Sep 2, 2024, 15:38 Elisha Hollander wrote: > > Just checked with 9.0.2 it it still gives the error... > > On Wed, Aug 28, 2024, 14:05 Alex Bennée wrote: > > Elisha Hollander writes: > > > Although it gives `undefined symb

Re: [PATCH 1/1] allow using a higher icount

But for qemu_plugin_update_ns On Mon, Sep 2, 2024, 15:38 Elisha Hollander wrote: > Just checked with 9.0.2 it it still gives the error... > > On Wed, Aug 28, 2024, 14:05 Alex Bennée wrote: > >> Elisha Hollander writes: >> >> > Although it gives `undefined symbol: qemu_plugin_scoreboard_free`.

Re: [PATCH 1/1] allow using a higher icount

Just checked with 9.0.2 it it still gives the error... On Wed, Aug 28, 2024, 14:05 Alex Bennée wrote: > Elisha Hollander writes: > > > Although it gives `undefined symbol: qemu_plugin_scoreboard_free`. But > > probably I messed something up... > > Are you using an older QEMU? We should trigger

Re: [PATCH 1/1] allow using a higher icount

Elisha Hollander writes: > Although it gives `undefined symbol: qemu_plugin_scoreboard_free`. But > probably I messed something up... Are you using an older QEMU? We should trigger an API warning if they are mismatched but maybe thats not working. > > On Tue, Aug 27, 2024, 14:59 Elisha Hollande

Re: [PATCH 1/1] allow using a higher icount

Although it gives `undefined symbol: qemu_plugin_scoreboard_free`. But probably I messed something up... On Tue, Aug 27, 2024, 14:59 Elisha Hollander wrote: > Oh nice, I didn't know that > > On Tue, Aug 27, 2024, 12:39 Alex Bennée wrote: > >> Elisha Hollander writes: >> >> > Signed-off-by: Eli

Re: [PATCH 1/1] allow using a higher icount

Oh nice, I didn't know that On Tue, Aug 27, 2024, 12:39 Alex Bennée wrote: > Elisha Hollander writes: > > > Signed-off-by: Elisha Hollander > > What is the use-case for this patch? > > If you are simply looking to slow the emulated system down please have a > look at: > > > https://qemu.readth

Re: [PATCH 1/1] allow using a higher icount

Elisha Hollander writes: > Signed-off-by: Elisha Hollander What is the use-case for this patch? If you are simply looking to slow the emulated system down please have a look at: https://qemu.readthedocs.io/en/master/about/emulation.html#limit-instructions-per-second which uses the plugin

Re: [PATCH 1/1] allow using a higher icount

Just wanted to ping the patch On Fri, Aug 16, 2024, 19:21 Elisha Hollander wrote: > Signed-off-by: Elisha Hollander > --- > accel/tcg/cpu-exec.c | 4 +--- > accel/tcg/icount-common.c | 4 ++-- > 2 files c

[PATCH 1/1] allow using a higher icount

Signed-off-by: Elisha Hollander --- accel/tcg/cpu-exec.c | 4 +--- accel/tcg/icount-common.c | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 8163295f34..4c2baf8ed4 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu