Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-21 Thread Markus Armbruster
John Snow writes: > On 9/18/20 6:55 AM, Markus Armbruster wrote: >> John Snow writes: > >>> We'll get to them in due time. For now, please admire the lipstick. >> If I take off my glasses and step six feet back, I just might be >> able to >> overlook it. >> > > I consider writing a nice __repr_

Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-18 Thread John Snow
On 9/18/20 6:55 AM, Markus Armbruster wrote: John Snow writes: We'll get to them in due time. For now, please admire the lipstick. If I take off my glasses and step six feet back, I just might be able to overlook it. I consider writing a nice __repr__ good habit, I'd prefer not to delete

Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-18 Thread Markus Armbruster
John Snow writes: > On 9/17/20 4:07 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 9/16/20 11:13 AM, Markus Armbruster wrote: John Snow writes: > > Let's replace "the indent" by "the indentation" globally. >>> >>> They're both cromulent as nouns and one is shor

Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-17 Thread John Snow
On 9/17/20 4:07 AM, Markus Armbruster wrote: John Snow writes: On 9/16/20 11:13 AM, Markus Armbruster wrote: John Snow writes: Let's replace "the indent" by "the indentation" globally. They're both cromulent as nouns and one is shorter. I'll switch in good faith; do you prefer "Inde

Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-17 Thread Markus Armbruster
John Snow writes: > On 9/16/20 11:13 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Code style tools really dislike the use of global keywords, because it >>> generally involves re-binding the name at runtime which can have strange >>> effects depending on when and how that global nam

Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-16 Thread John Snow
On 9/16/20 11:13 AM, Markus Armbruster wrote: John Snow writes: Code style tools really dislike the use of global keywords, because it generally involves re-binding the name at runtime which can have strange effects depending on when and how that global name is referenced in other modules. Ma

Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-16 Thread Markus Armbruster
John Snow writes: > Code style tools really dislike the use of global keywords, because it > generally involves re-binding the name at runtime which can have strange > effects depending on when and how that global name is referenced in > other modules. > > Make a little indent level manager inste

[PATCH 09/37] qapi/common.py: Add indent manager

2020-09-15 Thread John Snow
Code style tools really dislike the use of global keywords, because it generally involves re-binding the name at runtime which can have strange effects depending on when and how that global name is referenced in other modules. Make a little indent level manager instead. Signed-off-by: John Snow