Re: [PATCH 09/21] migration: Extract code to mark all parameters as present

2025-06-06 Thread Peter Xu
On Fri, Jun 06, 2025 at 12:51:58PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Jun 02, 2025 at 10:37:58PM -0300, Fabiano Rosas wrote: > >> MigrationParameters needs to have all of its has_* fields marked as > >> true when used as the return of query_migrate_parameters because the

Re: [PATCH 09/21] migration: Extract code to mark all parameters as present

2025-06-06 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jun 02, 2025 at 10:37:58PM -0300, Fabiano Rosas wrote: >> MigrationParameters needs to have all of its has_* fields marked as >> true when used as the return of query_migrate_parameters because the >> corresponding QMP command has all of its members non-optional by >> d

Re: [PATCH 09/21] migration: Extract code to mark all parameters as present

2025-06-06 Thread Peter Xu
On Mon, Jun 02, 2025 at 10:37:58PM -0300, Fabiano Rosas wrote: > MigrationParameters needs to have all of its has_* fields marked as > true when used as the return of query_migrate_parameters because the > corresponding QMP command has all of its members non-optional by > design, despite them being

[PATCH 09/21] migration: Extract code to mark all parameters as present

2025-06-02 Thread Fabiano Rosas
MigrationParameters needs to have all of its has_* fields marked as true when used as the return of query_migrate_parameters because the corresponding QMP command has all of its members non-optional by design, despite them being marked as optional in migration.json. Extract this code into a functi