Re: [PATCH 09/20] python/qemu: make 'args' style arguments immutable

2020-10-06 Thread Philippe Mathieu-Daudé
On 10/7/20 1:58 AM, John Snow wrote: > These arguments don't need to be mutable and aren't really used as > such. Clarify their types as immutable and adjust code to match where > necessary. > > In general, It's probably best not to accept a user-defined mutable > object and store it as internal o

[PATCH 09/20] python/qemu: make 'args' style arguments immutable

2020-10-06 Thread John Snow
These arguments don't need to be mutable and aren't really used as such. Clarify their types as immutable and adjust code to match where necessary. In general, It's probably best not to accept a user-defined mutable object and store it as internal object state unless there's a strong justification