Re: [PATCH 08/46] error: Avoid unnecessary error_propagate() after error_setg()

Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> Replace >> >> error_setg(&err, ...); >> error_propagate(errp, err); >> >> by >> >> error_setg(errp, ...); >> >> Related pattern: >> >> if (...) { >> error_setg(&err, ...); >>

Re: [PATCH 08/46] error: Avoid unnecessary error_propagate() after error_setg()

24.06.2020 19:43, Markus Armbruster wrote: Replace error_setg(&err, ...); error_propagate(errp, err); by error_setg(errp, ...); Related pattern: if (...) { error_setg(&err, ...); goto out; } ... out: error_propagate(errp, err); retu

Re: [PATCH 08/46] error: Avoid unnecessary error_propagate() after error_setg()

Eric Blake writes: > On 6/24/20 11:43 AM, Markus Armbruster wrote: >> Replace >> >> error_setg(&err, ...); >> error_propagate(errp, err); >> >> by >> >> error_setg(errp, ...); >> >> Related pattern: > > Nice explanation. > >> Bonus: the elimination of gotos will make later patches

Re: [PATCH 08/46] error: Avoid unnecessary error_propagate() after error_setg()

On 6/24/20 11:43 AM, Markus Armbruster wrote: Replace error_setg(&err, ...); error_propagate(errp, err); by error_setg(errp, ...); Related pattern: Nice explanation. Bonus: the elimination of gotos will make later patches in this series easier to review. Candidates for con

[PATCH 08/46] error: Avoid unnecessary error_propagate() after error_setg()

Replace error_setg(&err, ...); error_propagate(errp, err); by error_setg(errp, ...); Related pattern: if (...) { error_setg(&err, ...); goto out; } ... out: error_propagate(errp, err); return; When all paths to label out are that way, replace b