Re: [PATCH 08/41] opentitan: Rename memmap enum constants

2020-08-25 Thread Bin Meng
Hi Alistair, On Sat, Aug 22, 2020 at 3:04 AM Alistair Francis wrote: > > On Mon, Aug 17, 2020 at 2:53 AM Bin Meng wrote: > > > > On Sat, Aug 15, 2020 at 1:56 AM Philippe Mathieu-Daudé > > wrote: > > > > > > On 8/14/20 12:25 AM, Eduardo Habkost wrote: > > > > Some of the enum constant names con

Re: [PATCH 08/41] opentitan: Rename memmap enum constants

2020-08-21 Thread Alistair Francis
On Mon, Aug 17, 2020 at 2:53 AM Bin Meng wrote: > > On Sat, Aug 15, 2020 at 1:56 AM Philippe Mathieu-Daudé > wrote: > > > > On 8/14/20 12:25 AM, Eduardo Habkost wrote: > > > Some of the enum constant names conflict with the QOM type check > > > macros. This needs to be addressed to allow us to

Re: [PATCH 08/41] opentitan: Rename memmap enum constants

2020-08-17 Thread Bin Meng
On Sat, Aug 15, 2020 at 1:56 AM Philippe Mathieu-Daudé wrote: > > On 8/14/20 12:25 AM, Eduardo Habkost wrote: > > Some of the enum constant names conflict with the QOM type check > > macros. This needs to be addressed to allow us to transform the > > QOM type check macros into functions generated

Re: [PATCH 08/41] opentitan: Rename memmap enum constants

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:25 AM, Eduardo Habkost wrote: > Some of the enum constant names conflict with the QOM type check > macros. This needs to be addressed to allow us to transform the > QOM type check macros into functions generated by > OBJECT_DECLARE_TYPE(). > > Rename all the constants to IBEX_DEV_*,

Re: [PATCH 08/41] opentitan: Rename memmap enum constants

2020-08-14 Thread Alistair Francis
On Thu, Aug 13, 2020 at 3:29 PM Eduardo Habkost wrote: > > Some of the enum constant names conflict with the QOM type check > macros. This needs to be addressed to allow us to transform the > QOM type check macros into functions generated by > OBJECT_DECLARE_TYPE(). > > Rename all the constants t

[PATCH 08/41] opentitan: Rename memmap enum constants

2020-08-13 Thread Eduardo Habkost
Some of the enum constant names conflict with the QOM type check macros. This needs to be addressed to allow us to transform the QOM type check macros into functions generated by OBJECT_DECLARE_TYPE(). Rename all the constants to IBEX_DEV_*, to avoid conflicts. Signed-off-by: Eduardo Habkost --