Re: [PATCH 08/21] exec: Fix latent file_ram_alloc() error handling bug

2019-12-01 Thread Igor Mammedov
On Sat, 30 Nov 2019 20:42:27 +0100 Markus Armbruster wrote: > When os_mem_prealloc() fails, file_ram_alloc() calls qemu_ram_munmap() > and returns null. Except it doesn't when its @errp argument is null, > because it checks for failure with (errp && *errp). Messed up in > commit 056b68af77 "fix

[PATCH 08/21] exec: Fix latent file_ram_alloc() error handling bug

2019-11-30 Thread Markus Armbruster
When os_mem_prealloc() fails, file_ram_alloc() calls qemu_ram_munmap() and returns null. Except it doesn't when its @errp argument is null, because it checks for failure with (errp && *errp). Messed up in commit 056b68af77 "fix qemu exit on memory hotplug when allocation fails at prealloc time".