Re: [PATCH 08/21] block/backup: stricter backup_calculate_cluster_size()

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
17.05.2021 19:57, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: No reason to tolerate bdrv_get_info() errors except for ENOTSUP. Let's just error-out, it's simpler and safer. Hm, doesn’t look that much simpler to me.  Not sure how much safer it is, because the point

Re: [PATCH 08/21] block/backup: stricter backup_calculate_cluster_size()

2021-05-17 Thread Max Reitz
On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: No reason to tolerate bdrv_get_info() errors except for ENOTSUP. Let's just error-out, it's simpler and safer. Hm, doesn’t look that much simpler to me. Not sure how much safer it is, because the point was that in the target_does_cow case

[PATCH 08/21] block/backup: stricter backup_calculate_cluster_size()

2021-05-16 Thread Vladimir Sementsov-Ogievskiy
No reason to tolerate bdrv_get_info() errors except for ENOTSUP. Let's just error-out, it's simpler and safer. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/block/backup.c b/block/backup.c index f