Re: [PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

On Thu, Jun 13, 2024 at 2:43 PM Daniel P. Berrangé wrote: > On Tue, Jun 11, 2024 at 03:55:37PM +0200, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > > > > Rather than creating stubs for every command that just return > > > QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to

Re: [PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

On Tue, Jun 11, 2024 at 03:55:37PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Rather than creating stubs for every command that just return > > QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to > > fully exclude generation of the commands on Windows. > > > > The

Re: [PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

On Tue, Jun 11, 2024 at 11:13:00AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Rather than creating stubs for every command that just return > > QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to > > fully exclude generation of the commands on Windows. > > > > The

Re: [PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

On Tue, Jun 11, 2024 at 03:55:37PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Rather than creating stubs for every command that just return > > QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to > > fully exclude generation of the commands on Windows. > > > > The

Re: [PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

Daniel P. Berrangé writes: > Rather than creating stubs for every command that just return > QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to > fully exclude generation of the commands on Windows. > > The command will be rejected at QMP dispatch time instead, > avoiding reimplementing

Re: [PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

Daniel P. Berrangé writes: > Rather than creating stubs for every command that just return > QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to > fully exclude generation of the commands on Windows. > > The command will be rejected at QMP dispatch time instead, > avoiding reimplementing

[PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to fully exclude generation of the commands on Windows. The command will be rejected at QMP dispatch time instead, avoiding reimplementing rejection by blocking the stub commands.