Re: [PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-11 Thread David Hildenbrand
On 12.05.20 08:46, Philippe Mathieu-Daudé wrote: > On 5/12/20 8:01 AM, Cornelia Huck wrote: >> On Mon, 11 May 2020 14:21:27 +0200 >> Philippe Mathieu-Daudé wrote: >> >>> On 5/11/20 12:48 PM, Cornelia Huck wrote: On Sat, 9 May 2020 15:09:07 +0200 Philippe Mathieu-Daudé wrote: >

Re: [PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-11 Thread Philippe Mathieu-Daudé
On 5/12/20 8:01 AM, Cornelia Huck wrote: On Mon, 11 May 2020 14:21:27 +0200 Philippe Mathieu-Daudé wrote: On 5/11/20 12:48 PM, Cornelia Huck wrote: On Sat, 9 May 2020 15:09:07 +0200 Philippe Mathieu-Daudé wrote: As these declarations are restricted to !CONFIG_USER_ONLY in helper.c, onl

Re: [PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-11 Thread Cornelia Huck
On Mon, 11 May 2020 14:21:27 +0200 Philippe Mathieu-Daudé wrote: > On 5/11/20 12:48 PM, Cornelia Huck wrote: > > On Sat, 9 May 2020 15:09:07 +0200 > > Philippe Mathieu-Daudé wrote: > > > >> As these declarations are restricted to !CONFIG_USER_ONLY in > >> helper.c, only declare them when sys

Re: [PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-11 Thread Philippe Mathieu-Daudé
On 5/11/20 12:48 PM, Cornelia Huck wrote: On Sat, 9 May 2020 15:09:07 +0200 Philippe Mathieu-Daudé wrote: As these declarations are restricted to !CONFIG_USER_ONLY in helper.c, only declare them when system-mode emulation is used. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/int

Re: [PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-11 Thread Cornelia Huck
On Sat, 9 May 2020 15:09:07 +0200 Philippe Mathieu-Daudé wrote: > As these declarations are restricted to !CONFIG_USER_ONLY in > helper.c, only declare them when system-mode emulation is used. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/s390x/internal.h | 11 ++- > 1 file

[PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-09 Thread Philippe Mathieu-Daudé
As these declarations are restricted to !CONFIG_USER_ONLY in helper.c, only declare them when system-mode emulation is used. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/internal.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/s390x/internal.h b