Re: [PATCH 08/10] target/ppc: Fix gen_sc to use correct nip

2023-06-15 Thread BALATON Zoltan
On Thu, 15 Jun 2023, Nicholas Piggin wrote: On Thu Jun 15, 2023 at 7:27 AM AEST, BALATON Zoltan wrote: On Wed, 14 Jun 2023, Nicholas Piggin wrote: On Mon Jun 12, 2023 at 8:42 AM AEST, BALATON Zoltan wrote: Most exceptions are raised with nip pointing to the faulting instruction but the sc inst

Re: [PATCH 08/10] target/ppc: Fix gen_sc to use correct nip

2023-06-14 Thread Nicholas Piggin
On Thu Jun 15, 2023 at 7:27 AM AEST, BALATON Zoltan wrote: > On Wed, 14 Jun 2023, Nicholas Piggin wrote: > > On Mon Jun 12, 2023 at 8:42 AM AEST, BALATON Zoltan wrote: > >> Most exceptions are raised with nip pointing to the faulting > >> instruction but the sc instruction generating a syscall exce

Re: [PATCH 08/10] target/ppc: Fix gen_sc to use correct nip

2023-06-14 Thread BALATON Zoltan
On Wed, 14 Jun 2023, Nicholas Piggin wrote: On Mon Jun 12, 2023 at 8:42 AM AEST, BALATON Zoltan wrote: Most exceptions are raised with nip pointing to the faulting instruction but the sc instruction generating a syscall exception leaves nip pointing to next instruction. Fix gen_sc to not use gen

Re: [PATCH 08/10] target/ppc: Fix gen_sc to use correct nip

2023-06-14 Thread BALATON Zoltan
On Wed, 14 Jun 2023, Nicholas Piggin wrote: On Mon Jun 12, 2023 at 8:42 AM AEST, BALATON Zoltan wrote: Most exceptions are raised with nip pointing to the faulting instruction but the sc instruction generating a syscall exception leaves nip pointing to next instruction. Fix gen_sc to not use gen

Re: [PATCH 08/10] target/ppc: Fix gen_sc to use correct nip

2023-06-13 Thread Nicholas Piggin
On Mon Jun 12, 2023 at 8:42 AM AEST, BALATON Zoltan wrote: > Most exceptions are raised with nip pointing to the faulting > instruction but the sc instruction generating a syscall exception > leaves nip pointing to next instruction. Fix gen_sc to not use > gen_exception_err() which sets nip back bu

[PATCH 08/10] target/ppc: Fix gen_sc to use correct nip

2023-06-11 Thread BALATON Zoltan
Most exceptions are raised with nip pointing to the faulting instruction but the sc instruction generating a syscall exception leaves nip pointing to next instruction. Fix gen_sc to not use gen_exception_err() which sets nip back but correctly set nip to pc_next so we don't have to patch this in th