Re: [PATCH 08/10] accel/tcg: push i386 specific hacks into handle_cpu_interrupt callback

2023-03-20 Thread Richard Henderson
On 3/20/23 10:14, Alex Bennée wrote: This should be a tcg hook, not a sysemu hook, per the previous one. I would very much like it to never be NULL, but instead your new common_cpu_handle_interrupt function. I was trying to figure out how to instantiate a default but ran into const problems eve

Re: [PATCH 08/10] accel/tcg: push i386 specific hacks into handle_cpu_interrupt callback

2023-03-20 Thread Alex Bennée
Richard Henderson writes: > On 3/20/23 03:10, Alex Bennée wrote: >> Signed-off-by: Alex Bennée >> --- >> include/hw/core/sysemu-cpu-ops.h | 11 +++ >> target/i386/cpu-internal.h | 1 + >> accel/tcg/cpu-exec-softmmu.c | 16 >> accel/tcg/cpu-exec.c

Re: [PATCH 08/10] accel/tcg: push i386 specific hacks into handle_cpu_interrupt callback

2023-03-20 Thread Richard Henderson
On 3/20/23 03:10, Alex Bennée wrote: Signed-off-by: Alex Bennée --- include/hw/core/sysemu-cpu-ops.h | 11 +++ target/i386/cpu-internal.h | 1 + accel/tcg/cpu-exec-softmmu.c | 16 accel/tcg/cpu-exec.c | 31 ++- tar

[PATCH 08/10] accel/tcg: push i386 specific hacks into handle_cpu_interrupt callback

2023-03-20 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/hw/core/sysemu-cpu-ops.h | 11 +++ target/i386/cpu-internal.h | 1 + accel/tcg/cpu-exec-softmmu.c | 16 accel/tcg/cpu-exec.c | 31 ++- target/i386/cpu-sysemu.c | 17 +