Re: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp

2021-06-16 Thread Richard Henderson
On 6/16/21 2:37 PM, Taylor Simpson wrote: Yes, I'm confused. Why is signal frame unwinding in libgcc? Because it's tied to the compiler, and it was a decent solution back in 1997. I see llvm calls it libunwind, and only has special signal frame support for aarch64. I wonder if ever other ta

RE: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp

2021-06-16 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, June 16, 2021 9:51 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: laur...@vivier.eu; alex.ben...@linaro.org > Subject: Re: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp > > On

Re: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp

2021-06-16 Thread Richard Henderson
On 6/16/21 8:05 AM, Richard Henderson wrote: On 6/16/21 1:07 AM, Taylor Simpson wrote: +    /* + * The on-stack signal trampoline is no longer executed; + * however, the libgcc signal frame unwinding code checks + * for the presence of these two numeric magic values. + */ Hexag

Re: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp

2021-06-16 Thread Richard Henderson
On 6/16/21 1:07 AM, Taylor Simpson wrote: +/* + * The on-stack signal trampoline is no longer executed; + * however, the libgcc signal frame unwinding code checks + * for the presence of these two numeric magic values. + */ Hexagon uses musl, not libgcc. So, I'm not sure if

RE: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp

2021-06-16 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Tuesday, June 15, 2021 7:12 PM > To: qemu-devel@nongnu.org > Cc: laur...@vivier.eu; alex.ben...@linaro.org; Taylor Simpson > > Subject: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp > >

[PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Continue to initialize the words on the stack, as documented. However, use the off-stack trampoline. Cc: Taylor Simpson Signed-off-by: Richard Henderson --- linux-user/hexagon/target_signal.h | 2 ++ linux-user/hexagon/signal.c| 19 +-- 2 files changed, 19 insertions(+)