Re: [PATCH 07/18] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-09-30 Thread Jared Rossi
+    if (!virtio_read_many(block_offset, load_addr, blks_to_load)) { ... but this code here checks that virtio_read_many() now returns 0 to signal that there is an error... Either I need more coffee or one of the two if-conditions is wrong...? Hmm, I think you are sufficiently caffeinate

Re: [PATCH 07/18] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-09-30 Thread Thomas Huth
On 27/09/2024 19.15, Jared Rossi wrote: On 9/27/24 11:02 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from IPL ISO El Torito specific functions so that error recovery may be possible in the future. Functions that would pre

Re: [PATCH 07/18] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-09-27 Thread Jared Rossi
On 9/27/24 11:02 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from IPL ISO El Torito specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code

Re: [PATCH 07/18] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-09-27 Thread Thomas Huth
On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from IPL ISO El Torito specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/

[PATCH 07/18] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-09-26 Thread jrossi
From: Jared Rossi Remove panic-on-error from IPL ISO El Torito specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s390-ccw/bootmap.h | 17 +++--- pc-bios/s390-cc