Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-14 Thread Markus Armbruster
I found the commit message's description of reference resolution hard to understand. I think I understand it well enough now to ACK the design. Would be nice to work some of your explanations into the commit message, but we don't have time for that. So I'm merely fixing your QGA vs. QSD typo. We

Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-14 Thread Markus Armbruster
John Snow writes: > On Thu, Mar 13, 2025 at 2:30 PM Markus Armbruster wrote: > >> John Snow writes: >> >> > On Thu, Mar 13, 2025, 11:57 AM Markus Armbruster wrote: >> > >> >> John Snow writes: >> >> >> >> > On Thu, Mar 13, 2025 at 10:41 AM Markus Armbruster > >> > wrote: [...] >> >> >> Rega

Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-13 Thread John Snow
On Thu, Mar 13, 2025 at 2:30 PM Markus Armbruster wrote: > John Snow writes: > > > On Thu, Mar 13, 2025, 11:57 AM Markus Armbruster > wrote: > > > >> John Snow writes: > >> > >> > On Thu, Mar 13, 2025 at 10:41 AM Markus Armbruster > > >> > wrote: > >> > > >> >> John Snow writes: > >> >> > >>

Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-13 Thread Markus Armbruster
John Snow writes: > On Thu, Mar 13, 2025, 11:57 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > On Thu, Mar 13, 2025 at 10:41 AM Markus Armbruster >> > wrote: >> > >> >> John Snow writes: >> >> >> >> > On Thu, Mar 13, 2025 at 2:47 AM Markus Armbruster >> >> > wrote: >> >> > >> >>

Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-13 Thread John Snow
On Thu, Mar 13, 2025, 11:57 AM Markus Armbruster wrote: > John Snow writes: > > > On Thu, Mar 13, 2025 at 10:41 AM Markus Armbruster > > wrote: > > > >> John Snow writes: > >> > >> > On Thu, Mar 13, 2025 at 2:47 AM Markus Armbruster > wrote: > >> > > >> >> John Snow writes: > >> >> > >> >> >

Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-13 Thread John Snow
On Thu, Mar 13, 2025 at 2:47 AM Markus Armbruster wrote: > John Snow writes: > > > This patch does three things: > > > > 1. Record the current namespace context in pending_xrefs so it can be > >used for link resolution later, > > 2. Pass that recorded namespace context to find_obj() when res

Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-13 Thread Markus Armbruster
John Snow writes: > On Thu, Mar 13, 2025 at 10:41 AM Markus Armbruster > wrote: > >> John Snow writes: >> >> > On Thu, Mar 13, 2025 at 2:47 AM Markus Armbruster >> > wrote: >> > >> >> John Snow writes: >> >> >> >> > This patch does three things: >> >> > >> >> > 1. Record the current namespac

Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-13 Thread John Snow
On Thu, Mar 13, 2025 at 10:41 AM Markus Armbruster wrote: > John Snow writes: > > > On Thu, Mar 13, 2025 at 2:47 AM Markus Armbruster > wrote: > > > >> John Snow writes: > >> > >> > This patch does three things: > >> > > >> > 1. Record the current namespace context in pending_xrefs so it can b

Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-13 Thread Markus Armbruster
John Snow writes: > On Thu, Mar 13, 2025 at 2:47 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > This patch does three things: >> > >> > 1. Record the current namespace context in pending_xrefs so it can be >> >used for link resolution later, >> > 2. Pass that recorded namespace

Re: [PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-12 Thread Markus Armbruster
John Snow writes: > This patch does three things: > > 1. Record the current namespace context in pending_xrefs so it can be >used for link resolution later, > 2. Pass that recorded namespace context to find_obj() when resolving a >reference, and > 3. Wildly and completely rewrite find_obj

[PATCH 07/11] docs/qapi_domain: add namespace support to cross-references

2025-03-12 Thread John Snow
This patch does three things: 1. Record the current namespace context in pending_xrefs so it can be used for link resolution later, 2. Pass that recorded namespace context to find_obj() when resolving a reference, and 3. Wildly and completely rewrite find_obj(). cross-reference support is e