Re: [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader

2023-06-22 Thread Paolo Bonzini
On 6/22/23 10:42, Thomas Huth wrote: Only if run in a git repository, not in a tree generated with archive-source.sh which doesn't package roms/SLOF. So without the check below the build fails. This is not inteded, is it? I guess archive-source.sh needs to be changed to include the SLOF sou

Re: [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader

2023-06-22 Thread Thomas Huth
On 16/06/2023 17.20, Nina Schoetterl-Glausch wrote: On Mon, 2023-06-05 at 11:52 +0200, Paolo Bonzini wrote: In the beginning, the network bootloader was considered experimental and thus optional, but it is well established nowadays and configure always checks for roms/SLOF before compiling pc-bi

Re: [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader

2023-06-16 Thread Nina Schoetterl-Glausch
On Mon, 2023-06-05 at 11:52 +0200, Paolo Bonzini wrote: > In the beginning, the network bootloader was considered experimental and > thus optional, but it is well established nowadays and configure always > checks for roms/SLOF before compiling pc-bios/s390-ccw. Only if run in a git repository, no

Re: [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader

2023-06-06 Thread Thomas Huth
On 05/06/2023 11.52, Paolo Bonzini wrote: In the beginning, the network bootloader was considered experimental and thus optional, but it is well established nowadays and configure always checks for roms/SLOF before compiling pc-bios/s390-ccw. Therefore, it makes sense to always build it together

Re: [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader

2023-06-06 Thread Daniel P . Berrangé
On Mon, Jun 05, 2023 at 11:52:20AM +0200, Paolo Bonzini wrote: > In the beginning, the network bootloader was considered experimental and > thus optional, but it is well established nowadays and configure always > checks for roms/SLOF before compiling pc-bios/s390-ccw. > > Therefore, it makes sens

[PATCH 07/10] pc-bios/s390-ccw: always build network bootloader

2023-06-05 Thread Paolo Bonzini
In the beginning, the network bootloader was considered experimental and thus optional, but it is well established nowadays and configure always checks for roms/SLOF before compiling pc-bios/s390-ccw. Therefore, it makes sense to always build it together with the other part of the s390-ccw bios.