Re: [PATCH 06/46] error: Avoid error_propagate() when error is not used here

2020-06-27 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> When all we do with an Error we receive into a local variable is >> propagating to somewhere else, we can just as well receive it there >> right away. Coccinelle script: >> >> @@ >> identifier fun, err

Re: [PATCH 06/46] error: Avoid error_propagate() when error is not used here

2020-06-26 Thread Vladimir Sementsov-Ogievskiy
24.06.2020 19:43, Markus Armbruster wrote: When all we do with an Error we receive into a local variable is propagating to somewhere else, we can just as well receive it there right away. Coccinelle script: @@ identifier fun, err, errp; expression list args; @@ -fun

Re: [PATCH 06/46] error: Avoid error_propagate() when error is not used here

2020-06-25 Thread Markus Armbruster
Eric Blake writes: > On 6/24/20 11:43 AM, Markus Armbruster wrote: >> When all we do with an Error we receive into a local variable is >> propagating to somewhere else, we can just as well receive it there >> right away. Coccinelle script: > > This seems to be a recurring cleanup (witness commit

Re: [PATCH 06/46] error: Avoid error_propagate() when error is not used here

2020-06-24 Thread Eric Blake
On 6/24/20 11:43 AM, Markus Armbruster wrote: When all we do with an Error we receive into a local variable is propagating to somewhere else, we can just as well receive it there right away. Coccinelle script: This seems to be a recurring cleanup (witness commit 06592d7e, c0e90679, 6b62d961).

[PATCH 06/46] error: Avoid error_propagate() when error is not used here

2020-06-24 Thread Markus Armbruster
When all we do with an Error we receive into a local variable is propagating to somewhere else, we can just as well receive it there right away. Coccinelle script: @@ identifier fun, err, errp; expression list args; @@ -fun(args, &err); +fun(args, errp); .