Re: [PATCH 06/16] qapi/expr.py: Check type of 'data' member

2020-09-25 Thread Cleber Rosa
On Thu, Sep 24, 2020 at 08:50:27PM -0400, John Snow wrote: > On 9/24/20 8:31 PM, Cleber Rosa wrote: > > On Tue, Sep 22, 2020 at 05:13:03PM -0400, John Snow wrote: > > > Iterating over the members of data isn't going to work if it's not some > > > form of dict anyway, but for type safety, formalize

Re: [PATCH 06/16] qapi/expr.py: Check type of 'data' member

2020-09-24 Thread John Snow
On 9/24/20 8:31 PM, Cleber Rosa wrote: On Tue, Sep 22, 2020 at 05:13:03PM -0400, John Snow wrote: Iterating over the members of data isn't going to work if it's not some form of dict anyway, but for type safety, formalize it. Signed-off-by: John Snow --- scripts/qapi/expr.py | 7 +++ 1

Re: [PATCH 06/16] qapi/expr.py: Check type of 'data' member

2020-09-24 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:13:03PM -0400, John Snow wrote: > Iterating over the members of data isn't going to work if it's not some > form of dict anyway, but for type safety, formalize it. > > Signed-off-by: John Snow > --- > scripts/qapi/expr.py | 7 +++ > 1 file changed, 7 insertions(+)

Re: [PATCH 06/16] qapi/expr.py: Check type of 'data' member

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:13:03PM -0400, John Snow wrote: > Iterating over the members of data isn't going to work if it's not some > form of dict anyway, but for type safety, formalize it. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

[PATCH 06/16] qapi/expr.py: Check type of 'data' member

2020-09-22 Thread John Snow
Iterating over the members of data isn't going to work if it's not some form of dict anyway, but for type safety, formalize it. Signed-off-by: John Snow --- scripts/qapi/expr.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 3f5af5f5e