Re: [Virtio-fs] [PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-10-06 Thread Vivek Goyal
On Wed, Oct 06, 2021 at 03:35:30PM +0200, Christophe de Dinechin wrote: > > On 2021-09-30 at 11:30 -04, Vivek Goyal wrote... > > Add helpers to create/cleanup virtuqueues and use those helpers. I will > > Typo, virtuqueues -> virtqueues > > Also, while I'm nitpicking, virtqueue could be plural

Re: [Virtio-fs] [PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-10-06 Thread Christophe de Dinechin
On 2021-09-30 at 11:30 -04, Vivek Goyal wrote... > Add helpers to create/cleanup virtuqueues and use those helpers. I will Typo, virtuqueues -> virtqueues Also, while I'm nitpicking, virtqueue could be plural in commit description ;-) > need to reconfigure queues in later patches and using he

Re: [PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-10-05 Thread Stefan Hajnoczi
On Mon, Oct 04, 2021 at 03:58:09PM -0400, Vivek Goyal wrote: > On Mon, Oct 04, 2021 at 02:54:17PM +0100, Stefan Hajnoczi wrote: > > On Thu, Sep 30, 2021 at 11:30:30AM -0400, Vivek Goyal wrote: > > > Add helpers to create/cleanup virtuqueues and use those helpers. I will > > > > s/virtuqueues/virtq

Re: [PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-10-04 Thread Vivek Goyal
On Mon, Oct 04, 2021 at 02:54:17PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 30, 2021 at 11:30:30AM -0400, Vivek Goyal wrote: > > Add helpers to create/cleanup virtuqueues and use those helpers. I will > > s/virtuqueues/virtqueues/ > > > need to reconfigure queues in later patches and using hel

Re: [PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-10-04 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 11:30:30AM -0400, Vivek Goyal wrote: > Add helpers to create/cleanup virtuqueues and use those helpers. I will s/virtuqueues/virtqueues/ > need to reconfigure queues in later patches and using helpers will allow > reusing the code. > > Signed-off-by: Vivek Goyal > --- >

[PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-09-30 Thread Vivek Goyal
Add helpers to create/cleanup virtuqueues and use those helpers. I will need to reconfigure queues in later patches and using helpers will allow reusing the code. Signed-off-by: Vivek Goyal --- hw/virtio/vhost-user-fs.c | 87 +++ 1 file changed, 52 insertions(