Re: [PATCH 06/11] error: Use error_reportf_err() where appropriate

2020-04-27 Thread Eric Blake
On 4/27/20 3:53 AM, Markus Armbruster wrote: Eric Blake writes: Although it touches NBD, I'm happy for this to go through your tree with the larger series. +++ b/qemu-nbd.c @@ -856,8 +856,7 @@ int main(int argc, char **argv) } tlscreds = nbd_get_tls_creds(tlscredsid,

Re: [PATCH 06/11] error: Use error_reportf_err() where appropriate

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 10:53 AM, Markus Armbruster wrote: Eric Blake writes: On 4/24/20 2:20 PM, Markus Armbruster wrote: Replace error_report("...: %s", ..., error_get_pretty(err)); by error_reportf_err(err, "...: ", ...); Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --

Re: [PATCH 06/11] error: Use error_reportf_err() where appropriate

2020-04-27 Thread Markus Armbruster
Eric Blake writes: > On 4/24/20 2:20 PM, Markus Armbruster wrote: >> Replace >> >> error_report("...: %s", ..., error_get_pretty(err)); >> >> by >> >> error_reportf_err(err, "...: ", ...); > > Reviewed-by: Eric Blake > >> >> Signed-off-by: Markus Armbruster >> --- >> chardev/char-so

Re: [PATCH 06/11] error: Use error_reportf_err() where appropriate

2020-04-24 Thread Eric Blake
On 4/24/20 2:20 PM, Markus Armbruster wrote: Replace error_report("...: %s", ..., error_get_pretty(err)); by error_reportf_err(err, "...: ", ...); Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- chardev/char-socket.c | 5 +++-- hw/sd/pxa2xx_mmci.c | 4 ++--

[PATCH 06/11] error: Use error_reportf_err() where appropriate

2020-04-24 Thread Markus Armbruster
Replace error_report("...: %s", ..., error_get_pretty(err)); by error_reportf_err(err, "...: ", ...); Signed-off-by: Markus Armbruster --- chardev/char-socket.c | 5 +++-- hw/sd/pxa2xx_mmci.c | 4 ++-- hw/sd/sd.c| 4 ++-- hw/usb/dev-mtp.c | 9 + qemu-nbd.c