Re: [PATCH 06/10] includes: move irq definitions out of cpu-all.h

2023-03-21 Thread Richard Henderson
On 3/21/23 09:06, Alessandro Di Federico wrote: On Mon, 20 Mar 2023 10:10:31 + Alex Bennée wrote: +#define CPU_INTERRUPT_HARD0x0002 Out of curiosity, do we have a policy when to use `const` globals as opposed to `#define`? In theory, if a constant is never used in any preprocesso

Re: [PATCH 06/10] includes: move irq definitions out of cpu-all.h

2023-03-20 Thread Richard Henderson
On 3/20/23 03:10, Alex Bennée wrote: These are common across all versions of the system so it would help if we could use them for common code. Signed-off-by: Alex Bennée --- include/exec/cpu-all.h | 52 +- include/exec/cpu-irq.h | 83 +++

[PATCH 06/10] includes: move irq definitions out of cpu-all.h

2023-03-20 Thread Alex Bennée
These are common across all versions of the system so it would help if we could use them for common code. Signed-off-by: Alex Bennée --- include/exec/cpu-all.h | 52 +- include/exec/cpu-irq.h | 83 ++ include/exec/poison.h | 13 ---