Re: [PATCH 05/21] block: rename backup-top to copy-before-write

2021-05-18 Thread Max Reitz
On 17.05.21 21:42, Vladimir Sementsov-Ogievskiy wrote: 17.05.2021 19:05, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We are going to convert backup_top to full featured public filter, which can be used in separate of backup job. Start from renaming from "how it used"

Re: [PATCH 05/21] block: rename backup-top to copy-before-write

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
17.05.2021 19:05, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We are going to convert backup_top to full featured public filter, which can be used in separate of backup job. Start from renaming from "how it used" to "what it does". Is this safe?  The name was extern

Re: [PATCH 05/21] block: rename backup-top to copy-before-write

2021-05-17 Thread Max Reitz
On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We are going to convert backup_top to full featured public filter, which can be used in separate of backup job. Start from renaming from "how it used" to "what it does". Is this safe? The name was externally visible in queries after all.

[PATCH 05/21] block: rename backup-top to copy-before-write

2021-05-16 Thread Vladimir Sementsov-Ogievskiy
We are going to convert backup_top to full featured public filter, which can be used in separate of backup job. Start from renaming from "how it used" to "what it does". While updating comments in 283 iotest, drop and rephrase also things about ".active", as this field is now dropped, and filter d