On Sat May 18, 2024 at 9:07 PM AEST, Richard Henderson wrote:
> On 5/18/24 11:31, Nicholas Piggin wrote:
> > +static void gen_attn(DisasContext *ctx)
> > +{
> > +#if defined(CONFIG_USER_ONLY)
> > +GEN_PRIV(ctx);
> > +#else
> > +gen_helper_attn(tcg_env);
> > +#endif
> > +}
>
> You forgot to
On Sat May 18, 2024 at 9:05 PM AEST, Richard Henderson wrote:
> On 5/18/24 11:31, Nicholas Piggin wrote:
> > @@ -425,17 +426,17 @@ static void powerpc_set_excp_state(PowerPCCPU *cpu,
> > target_ulong vector,
> > env->reserve_addr = -1;
> > }
> >
> > -static void powerpc_mcheck_checkstop
On 5/18/24 11:31, Nicholas Piggin wrote:
+static void gen_attn(DisasContext *ctx)
+{
+#if defined(CONFIG_USER_ONLY)
+GEN_PRIV(ctx);
+#else
+gen_helper_attn(tcg_env);
+#endif
+}
You forgot to check priv in system mode.
Better as
GEN_PRIV(ctx);
#ifndef CONFIG_USER_ONLY
gen_helper
On 5/18/24 11:31, Nicholas Piggin wrote:
@@ -425,17 +426,17 @@ static void powerpc_set_excp_state(PowerPCCPU *cpu,
target_ulong vector,
env->reserve_addr = -1;
}
-static void powerpc_mcheck_checkstop(CPUPPCState *env)
-{
-/* KVM guests always have MSR[ME] enabled */
#ifdef CONF
attn is an implementation-specific instruction that on POWER (and G5/
970) can be enabled with a HID bit (disabled = illegal), and executing
it causes the host processor to stop and the service processor to be
notified. Generally used for debugging.
Implement attn and make it checkstop the system,
