Re: [PATCH 05/14] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-05 Thread Peter Xu
On Wed, Oct 05, 2022 at 09:40:53AM -0400, Peter Xu wrote: > On Wed, Oct 05, 2022 at 12:18:00PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Tue, Oct 04, 2022 at 02:55:10PM +0100, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: >

Re: [PATCH 05/14] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-05 Thread Peter Xu
On Wed, Oct 05, 2022 at 12:18:00PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Tue, Oct 04, 2022 at 02:55:10PM +0100, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > Don't take the bitmap mutex when sending pages, or when bei

Re: [PATCH 05/14] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-05 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Oct 04, 2022 at 02:55:10PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Don't take the bitmap mutex when sending pages, or when being throttled by > > > migration_rate_limit() (which is a bit tricky to call it h

Re: [PATCH 05/14] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-04 Thread Peter Xu
On Tue, Oct 04, 2022 at 02:55:10PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Don't take the bitmap mutex when sending pages, or when being throttled by > > migration_rate_limit() (which is a bit tricky to call it here in ram code, > > but seems still helpful).

Re: [PATCH 05/14] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-04 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Don't take the bitmap mutex when sending pages, or when being throttled by > migration_rate_limit() (which is a bit tricky to call it here in ram code, > but seems still helpful). > > It prepares for the possibility of concurrently sending pages in >1 thread

[PATCH 05/14] migration: Yield bitmap_mutex properly when sending/sleeping

2022-09-20 Thread Peter Xu
Don't take the bitmap mutex when sending pages, or when being throttled by migration_rate_limit() (which is a bit tricky to call it here in ram code, but seems still helpful). It prepares for the possibility of concurrently sending pages in >1 threads using the function ram_save_host_page() becaus