Re: [PATCH 05/12] pc-bios/s390-ccw/virtio-blkdev: Remove virtio_assume_scsi()

2022-07-01 Thread Eric Farman
On Tue, 2022-06-28 at 15:10 +0200, Thomas Huth wrote: > The virtio_assume_scsi() function is very questionable: First, it > is only called for virtio-blk, and not for virtio-scsi, so the naming > is already quite confusing. Second, it is called if we detected a > "invalid" IPL disk, trying to fix i

[PATCH 05/12] pc-bios/s390-ccw/virtio-blkdev: Remove virtio_assume_scsi()

2022-06-28 Thread Thomas Huth
The virtio_assume_scsi() function is very questionable: First, it is only called for virtio-blk, and not for virtio-scsi, so the naming is already quite confusing. Second, it is called if we detected a "invalid" IPL disk, trying to fix it by blindly setting a sector size of 512. This of course won'