Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 02:41:41PM +, Peter Maydell wrote: > On Wed, 16 Mar 2022 at 13:44, Daniel P. Berrangé wrote: > > > > On Thu, Feb 24, 2022 at 08:14:47PM +, Peter Maydell wrote: > > > On Thu, 24 Feb 2022 at 19:50, Marc-André Lureau > > > wrote: > > > > On Thu, Feb 24, 2022 at 11:23

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-03-16 Thread Peter Maydell
On Wed, 16 Mar 2022 at 13:44, Daniel P. Berrangé wrote: > > On Thu, Feb 24, 2022 at 08:14:47PM +, Peter Maydell wrote: > > On Thu, 24 Feb 2022 at 19:50, Marc-André Lureau > > wrote: > > > On Thu, Feb 24, 2022 at 11:23 PM Peter Maydell > > > wrote: > > >> You're probably building with a newe

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-03-16 Thread Daniel P . Berrangé
On Thu, Feb 24, 2022 at 08:14:47PM +, Peter Maydell wrote: > On Thu, 24 Feb 2022 at 19:50, Marc-André Lureau > wrote: > > On Thu, Feb 24, 2022 at 11:23 PM Peter Maydell > > wrote: > >> You're probably building with a newer glib, and possibly also > >> a newer mingw. > >> > >> I've cc'd Stefa

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-02-24 Thread Marc-André Lureau
Hi On Fri, Feb 25, 2022 at 1:41 AM Stefan Weil wrote: > Am 24.02.22 um 20:12 schrieb Peter Maydell: > > > On Thu, 24 Feb 2022 at 18:38, wrote: > >> From: Marc-André Lureau > >> > >> This workaround was added in commit 95df51a4 ("w32: Always use standard > >> instead of native format strings"),

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-02-24 Thread Stefan Weil
Am 24.02.22 um 20:12 schrieb Peter Maydell: On Thu, 24 Feb 2022 at 18:38, wrote: From: Marc-André Lureau This workaround was added in commit 95df51a4 ("w32: Always use standard instead of native format strings"), as it claimed glib was using __printf__ attribute. This is surprising, since gl

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-02-24 Thread Peter Maydell
On Thu, 24 Feb 2022 at 19:50, Marc-André Lureau wrote: > On Thu, Feb 24, 2022 at 11:23 PM Peter Maydell > wrote: >> You're probably building with a newer glib, and possibly also >> a newer mingw. >> >> I've cc'd Stefan Weil who might know whether we can drop this >> workaround as far as the ming

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-02-24 Thread Marc-André Lureau
Hi Peter On Thu, Feb 24, 2022 at 11:23 PM Peter Maydell wrote: > On Thu, 24 Feb 2022 at 18:38, wrote: > > > > From: Marc-André Lureau > > > > This workaround was added in commit 95df51a4 ("w32: Always use standard > > instead of native format strings"), as it claimed glib was using > > __print

Re: [PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-02-24 Thread Peter Maydell
On Thu, 24 Feb 2022 at 18:38, wrote: > > From: Marc-André Lureau > > This workaround was added in commit 95df51a4 ("w32: Always use standard > instead of native format strings"), as it claimed glib was using > __printf__ attribute. This is surprising, since glib has always used > G_GNUC_PRINTF wh

[PATCH 05/12] compiler.h: drop __printf__ macro MinGW/glib workaround

2022-02-24 Thread marcandre . lureau
From: Marc-André Lureau This workaround was added in commit 95df51a4 ("w32: Always use standard instead of native format strings"), as it claimed glib was using __printf__ attribute. This is surprising, since glib has always used G_GNUC_PRINTF which, as the name implies, uses __gnu_printf__ when