Re: [PATCH 04/13] exec/cpu-all: allow to include specific cpu

2025-03-18 Thread Richard Henderson
On 3/17/25 21:51, Pierrick Bouvier wrote: Including "cpu.h" from code that is not compiled per target is ambiguous by definition. Thus we introduce a conditional include, to allow every architecture to set this, to point to the correct definition. hw/X or target/X will now include directly "targ

Re: [PATCH 04/13] exec/cpu-all: allow to include specific cpu

2025-03-18 Thread Pierrick Bouvier
On 3/18/25 15:36, Richard Henderson wrote: On 3/18/25 15:25, Pierrick Bouvier wrote: On 3/18/25 15:21, Richard Henderson wrote: On 3/18/25 15:16, Pierrick Bouvier wrote: This doesn't make any sense to me.  CPU_INCLUDE is defined within the very file that you're trying to include by avoiding "

Re: [PATCH 04/13] exec/cpu-all: allow to include specific cpu

2025-03-18 Thread Richard Henderson
On 3/18/25 15:25, Pierrick Bouvier wrote: On 3/18/25 15:21, Richard Henderson wrote: On 3/18/25 15:16, Pierrick Bouvier wrote: This doesn't make any sense to me.  CPU_INCLUDE is defined within the very file that you're trying to include by avoiding "cpu.h". Every target/X/cpu.h includes cpu

Re: [PATCH 04/13] exec/cpu-all: allow to include specific cpu

2025-03-18 Thread Pierrick Bouvier
On 3/18/25 15:21, Richard Henderson wrote: On 3/18/25 15:16, Pierrick Bouvier wrote: This doesn't make any sense to me.  CPU_INCLUDE is defined within the very file that you're trying to include by avoiding "cpu.h". Every target/X/cpu.h includes cpu-all.h, which includes "cpu.h" itself, rely

Re: [PATCH 04/13] exec/cpu-all: allow to include specific cpu

2025-03-18 Thread Richard Henderson
On 3/18/25 15:16, Pierrick Bouvier wrote: This doesn't make any sense to me.  CPU_INCLUDE is defined within the very file that you're trying to include by avoiding "cpu.h". Every target/X/cpu.h includes cpu-all.h, which includes "cpu.h" itself, relying on per target include path set by build

Re: [PATCH 04/13] exec/cpu-all: allow to include specific cpu

2025-03-18 Thread Pierrick Bouvier
On 3/18/25 15:11, Richard Henderson wrote: On 3/17/25 21:51, Pierrick Bouvier wrote: Including "cpu.h" from code that is not compiled per target is ambiguous by definition. Thus we introduce a conditional include, to allow every architecture to set this, to point to the correct definition. hw/X

[PATCH 04/13] exec/cpu-all: allow to include specific cpu

2025-03-17 Thread Pierrick Bouvier
Including "cpu.h" from code that is not compiled per target is ambiguous by definition. Thus we introduce a conditional include, to allow every architecture to set this, to point to the correct definition. hw/X or target/X will now include directly "target/X/cpu.h", and "target/X/cpu.h" will defin