John Snow writes:
> On 4/24/21 2:38 AM, Markus Armbruster wrote:
>> Mixing f-string and % interpolation. I doubt we'd write it this way
>> from scratch. I recommend to either stick to % for now (leave
>> conversion to f-strings for later), or conver the column formatting,
>> too, even though it
On 4/24/21 2:38 AM, Markus Armbruster wrote:
Mixing f-string and % interpolation. I doubt we'd write it this way
from scratch. I recommend to either stick to % for now (leave
conversion to f-strings for later), or conver the column formatting,
too, even though it's not related to the patch's pu
On 4/24/21 2:38 AM, Markus Armbruster wrote:
Not mentioned in the commit message: you add a default parameter value.
It's not used; there's just one caller, and it passes a value.
Intentional?
No. Leftover from an earlier version where it was used. It can be made
to always be an explicit para
John Snow writes:
> With the QAPISourceInfo(None, None, None) construct gone, there's not
> really any reason to have to specify that a file starts on the first
> line.
>
> Remove it from the initializer and have it default to 1.
>
> Remove the last vestiges where we check for 'line' being unset.
With the QAPISourceInfo(None, None, None) construct gone, there's not
really any reason to have to specify that a file starts on the first
line.
Remove it from the initializer and have it default to 1.
Remove the last vestiges where we check for 'line' being unset. That
won't happen again, now!
