Re: [PATCH 03/16] rust: pass rustc_args when building all crates

2024-10-21 Thread Paolo Bonzini
Il mar 22 ott 2024, 04:35 Junjie Mao ha scritto: > > Paolo Bonzini writes: > > > On Mon, Oct 21, 2024 at 8:16 AM Zhao Liu wrote: > >> unsafe_op_in_unsafe_fn is allowed in > >> rust/qemu-api/src/lib.rs. So should we wrap the bindings in a separate > >> lib (similar to the rust/bindings in the Li

Re: [PATCH 03/16] rust: pass rustc_args when building all crates

2024-10-21 Thread Junjie Mao
Paolo Bonzini writes: > On Mon, Oct 21, 2024 at 8:16 AM Zhao Liu wrote: >> unsafe_op_in_unsafe_fn is allowed in >> rust/qemu-api/src/lib.rs. So should we wrap the bindings in a separate >> lib (similar to the rust/bindings in the Linux kernel)? >> >> This way, the special lint settings can be

Re: [PATCH 03/16] rust: pass rustc_args when building all crates

2024-10-21 Thread Zhao Liu
On Mon, Oct 21, 2024 at 03:38:06PM +0200, Paolo Bonzini wrote: > Date: Mon, 21 Oct 2024 15:38:06 +0200 > From: Paolo Bonzini > Subject: Re: [PATCH 03/16] rust: pass rustc_args when building all crates > > On Mon, Oct 21, 2024 at 8:16 AM Zhao Liu wrote: > > unsafe_op_in_un

Re: [PATCH 03/16] rust: pass rustc_args when building all crates

2024-10-21 Thread Paolo Bonzini
On Mon, Oct 21, 2024 at 8:16 AM Zhao Liu wrote: > unsafe_op_in_unsafe_fn is allowed in > rust/qemu-api/src/lib.rs. So should we wrap the bindings in a separate > lib (similar to the rust/bindings in the Linux kernel)? > > This way, the special lint settings can be applied only to the binding > fil

Re: [PATCH 03/16] rust: pass rustc_args when building all crates

2024-10-20 Thread Zhao Liu
On Tue, Oct 15, 2024 at 03:17:21PM +0200, Paolo Bonzini wrote: > Date: Tue, 15 Oct 2024 15:17:21 +0200 > From: Paolo Bonzini > Subject: [PATCH 03/16] rust: pass rustc_args when building all crates > X-Mailer: git-send-email 2.46.2 > > rustc_args is needed to smooth the diff

[PATCH 03/16] rust: pass rustc_args when building all crates

2024-10-15 Thread Paolo Bonzini
rustc_args is needed to smooth the difference in warnings between the various versions of rustc. Always include those arguments. Signed-off-by: Paolo Bonzini --- meson.build | 18 +++--- rust/qemu-api/meson.build | 2 +- rust/qemu-api/src/device_class.